address feedback

Author: vdusek

src/crawlee/_types.py

@@ -434,8 +434,8 @@ def __call__(
 
         Args:
             id: The ID of the `KeyValueStore` to get.
-            name: The name of the `KeyValueStore` to get (global scope).
-            alias: The alias of the `KeyValueStore` to get (run scope, unnamed).
+            name: The name of the `KeyValueStore` to get (global scope, named storage).
+            alias: The alias of the `KeyValueStore` to get (run scope, unnamed storage).
         """
 
 
@@ -456,8 +456,8 @@ def __call__(
 
         Args:
             id: The ID of the `KeyValueStore` to get.
-            name: The name of the `KeyValueStore` to get (global scope).
-            alias: The alias of the `KeyValueStore` to get (run scope, unnamed).
+            name: The name of the `KeyValueStore` to get (global scope, named storage).
+            alias: The alias of the `KeyValueStore` to get (run scope, unnamed storage).
         """
 
 
@@ -482,8 +482,8 @@ def __call__(
         Args:
             data: The data to push to the `Dataset`.
             dataset_id: The ID of the `Dataset` to push the data to.
-            dataset_name: The name of the `Dataset` to push the data to (global scope).
-            dataset_alias: The alias of the `Dataset` to push the data to (run scope, unnamed).
+            dataset_name: The name of the `Dataset` to push the data to (global scope, named storage).
+            dataset_alias: The alias of the `Dataset` to push the data to (run scope, unnamed storage).
             **kwargs: Additional keyword arguments.
         """
 

src/crawlee/crawlers/_basic/_basic_crawler.py

@@ -784,8 +784,8 @@ async def get_data(
 
         Args:
             dataset_id: The ID of the `Dataset`.
-            dataset_name: The name of the `Dataset` (global scope).
-            dataset_alias: The alias of the `Dataset` (run scope, unnamed).
+            dataset_name: The name of the `Dataset` (global scope, named storage).
+            dataset_alias: The alias of the `Dataset` (run scope, unnamed storage).
             kwargs: Keyword arguments to be passed to the `Dataset.get_data()` method.
 
         Returns:
@@ -809,9 +809,9 @@ async def export_data(
 
         Args:
             path: The destination file path. Must end with '.json' or '.csv'.
-            dataset_id: The ID of the Dataset to export from. If None, uses `name` parameter instead.
-            dataset_name: The name of the Dataset to export from (global scope). If None, uses `id` parameter instead.
-            dataset_alias: The alias of the Dataset to export from (run scope, unnamed).
+            dataset_id: The ID of the Dataset to export from.
+            dataset_name: The name of the Dataset to export from (global scope, named storage).
+            dataset_alias: The alias of the Dataset to export from (run scope, unnamed storage).
         """
         dataset = await self.get_dataset(id=dataset_id, name=dataset_name, alias=dataset_alias)
 
@@ -841,8 +841,8 @@ async def _push_data(
         Args:
             data: The data to push to the `Dataset`.
             dataset_id: The ID of the `Dataset`.
-            dataset_name: The name of the `Dataset` (global scope).
-            dataset_alias: The alias of the `Dataset` (run scope, unnamed).
+            dataset_name: The name of the `Dataset` (global scope, named storage).
+            dataset_alias: The alias of the `Dataset` (run scope, unnamed storage).
             kwargs: Keyword arguments to be passed to the `Dataset.push_data()` method.
         """
         dataset = await self.get_dataset(id=dataset_id, name=dataset_name, alias=dataset_alias)

src/crawlee/storage_clients/_file_system/_dataset_client.py

@@ -102,8 +102,8 @@ async def open(
 
         Args:
             id: The ID of the dataset to open. If provided, searches for existing dataset by ID.
-            name: The name of the dataset for named storages. Mutually exclusive with alias.
-            alias: The alias of the dataset for unnamed storages. Mutually exclusive with name.
+            name: The name of the dataset for named (global scope) storages.
+            alias: The alias of the dataset for unnamed (run scope) storages.
             configuration: The configuration object containing storage directory settings.
 
         Returns:

src/crawlee/storage_clients/_file_system/_key_value_store_client.py

@@ -101,8 +101,8 @@ async def open(
 
         Args:
             id: The ID of the key-value store to open. If provided, searches for existing store by ID.
-            name: The name of the key-value store for named storages. Mutually exclusive with alias.
-            alias: The alias of the key-value store for unnamed storages. Mutually exclusive with name.
+            name: The name of the key-value store for named (global scope) storages.
+            alias: The alias of the key-value store for unnamed (run scope) storages.
             configuration: The configuration object containing storage directory settings.
 
         Returns:

src/crawlee/storage_clients/_file_system/_request_queue_client.py

@@ -153,8 +153,8 @@ async def open(
 
         Args:
             id: The ID of the request queue to open. If provided, searches for existing queue by ID.
-            name: The name of the request queue for named storages. Mutually exclusive with alias.
-            alias: The alias of the request queue for unnamed storages. Mutually exclusive with name.
+            name: The name of the request queue for named (global scope) storages.
+            alias: The alias of the request queue for unnamed (run scope) storages.
             configuration: The configuration object containing storage directory settings.
 
         Returns:

src/crawlee/storage_clients/_memory/_dataset_client.py

@@ -63,8 +63,8 @@ async def open(
 
         Args:
             id: The ID of the dataset. If not provided, a random ID will be generated.
-            name: The name of the dataset for named storages. Mutually exclusive with alias.
-            alias: The alias of the dataset for unnamed storages. Mutually exclusive with name.
+            name: The name of the dataset for named (global scope) storages.
+            alias: The alias of the dataset for unnamed (run scope) storages.
 
         Returns:
             An instance for the opened or created storage client.

src/crawlee/storage_clients/_memory/_key_value_store_client.py

@@ -61,8 +61,8 @@ async def open(
 
         Args:
             id: The ID of the key-value store. If not provided, a random ID will be generated.
-            name: The name of the key-value store for named storages. Mutually exclusive with alias.
-            alias: The alias of the key-value store for unnamed storages. Mutually exclusive with name.
+            name: The name of the key-value store for named (global scope) storages.
+            alias: The alias of the key-value store for unnamed (run scope) storages.
 
         Returns:
             An instance for the opened or created storage client.

src/crawlee/storage_clients/_memory/_request_queue_client.py

@@ -73,8 +73,8 @@ async def open(
 
         Args:
             id: The ID of the request queue. If not provided, a random ID will be generated.
-            name: The name of the request queue for named storages. Mutually exclusive with alias.
-            alias: The alias of the request queue for unnamed storages. Mutually exclusive with name.
+            name: The name of the request queue for named (global scope) storages.
+            alias: The alias of the request queue for unnamed (run scope) storages.
 
         Returns:
             An instance for the opened or created storage client.

tests/unit/storages/test_key_value_store.py

@@ -909,30 +909,6 @@ async def test_default_vs_alias_default_equivalence(
     await default_kvs.drop()
 
 
-async def test_alias_parameter_validation(
-    storage_client: StorageClient,
-    configuration: Configuration,
-) -> None:
-    """Test alias parameter validation."""
-    # Should not allow both name and alias
-    with pytest.raises(ValueError, match=r'Only one of'):
-        await KeyValueStore.open(
-            name='test',
-            alias='test',
-            storage_client=storage_client,
-            configuration=configuration,
-        )
-
-    # Valid alias should work
-    alias_kvs = await KeyValueStore.open(
-        alias='valid_alias',
-        storage_client=storage_client,
-        configuration=configuration,
-    )
-    assert alias_kvs.name is None
-    await alias_kvs.drop()
-
-
 async def test_multiple_alias_isolation(
     storage_client: StorageClient,
     configuration: Configuration,

tests/unit/storages/test_request_queue.py

@@ -1018,30 +1018,6 @@ async def test_default_vs_alias_default_equivalence(
     await default_rq.drop()
 
 
-async def test_alias_parameter_validation(
-    storage_client: StorageClient,
-    configuration: Configuration,
-) -> None:
-    """Test alias parameter validation."""
-    # Should not allow both name and alias
-    with pytest.raises(ValueError, match=r'Only one of'):
-        await RequestQueue.open(
-            name='test',
-            alias='test',
-            storage_client=storage_client,
-            configuration=configuration,
-        )
-
-    # Valid alias should work
-    alias_rq = await RequestQueue.open(
-        alias='valid_alias',
-        storage_client=storage_client,
-        configuration=configuration,
-    )
-    assert alias_rq.name is None
-    await alias_rq.drop()
-
-
 async def test_multiple_alias_isolation(
     storage_client: StorageClient,
     configuration: Configuration,