Skip to content

Commit 59aa5d1

Browse files
committed
Address more feedback
1 parent 94e0f39 commit 59aa5d1

File tree

5 files changed

+296
-220
lines changed

5 files changed

+296
-220
lines changed

src/crawlee/_types.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -610,7 +610,7 @@ class GetDataKwargs(TypedDict):
610610
"""The maximum number of items to retrieve. Unlimited if None."""
611611

612612
clean: NotRequired[bool]
613-
"""Return only non-empty items and excludes hidden fields. Shortcut for skip_hidden and skip_empty."""
613+
"""Return only non-empty items and excludes hidden fields. Shortcut for `skip_hidden` and `skip_empty`."""
614614

615615
desc: NotRequired[bool]
616616
"""Set to True to sort results in descending order."""

src/crawlee/storage_clients/_file_system/_key_value_store_client.py

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -419,7 +419,17 @@ async def iterate_keys(
419419

420420
@override
421421
async def get_public_url(self, *, key: str) -> str:
422-
raise NotImplementedError('Public URLs are not supported for file system key-value stores.')
422+
"""Return a file:// URL for the given key.
423+
424+
Args:
425+
key: The key to get the public URL for.
426+
427+
Returns:
428+
A file:// URL pointing to the file on the local filesystem.
429+
"""
430+
record_path = self.path_to_kvs / self._encode_key(key)
431+
absolute_path = record_path.absolute()
432+
return absolute_path.as_uri()
423433

424434
async def _update_metadata(
425435
self,

0 commit comments

Comments
 (0)