Skip to content

Commit 5d39923

Browse files
committed
Improve tests
1 parent 19b7ea3 commit 5d39923

File tree

2 files changed

+5
-28
lines changed

2 files changed

+5
-28
lines changed

tests/unit/storages/test_dataset.py

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -849,30 +849,6 @@ async def test_default_vs_alias_default_equivalence(
849849
await default_dataset.drop()
850850

851851

852-
async def test_alias_parameter_validation(
853-
storage_client: StorageClient,
854-
configuration: Configuration,
855-
) -> None:
856-
"""Test alias parameter validation."""
857-
# Should not allow both name and alias
858-
with pytest.raises(ValueError, match=r'Only one of'):
859-
await Dataset.open(
860-
name='test',
861-
alias='test',
862-
storage_client=storage_client,
863-
configuration=configuration,
864-
)
865-
866-
# Valid alias should work
867-
alias_dataset = await Dataset.open(
868-
alias='valid_alias',
869-
storage_client=storage_client,
870-
configuration=configuration,
871-
)
872-
assert alias_dataset.name is None
873-
await alias_dataset.drop()
874-
875-
876852
async def test_multiple_alias_isolation(
877853
storage_client: StorageClient,
878854
configuration: Configuration,

tests/unit/storages/test_request_queue.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -667,17 +667,18 @@ async def test_open_with_alias(
667667
assert rq_2.name is None
668668

669669
# Add different requests to each
670-
await rq_1.add_request('https://example1.com')
671-
await rq_2.add_request('https://example2.com')
670+
await rq_1.add_request('https://example.com/1')
671+
await rq_1.add_request('https://example.com/2')
672+
await rq_2.add_request('https://example.com/3')
672673

673674
# Verify data isolation
674675
request_1 = await rq_1.fetch_next_request()
675676
request_2 = await rq_2.fetch_next_request()
676677

677678
assert request_1 is not None
678679
assert request_2 is not None
679-
assert request_1.url == 'https://example1.com'
680-
assert request_2.url == 'https://example2.com'
680+
assert request_1.url == 'https://example.com/1'
681+
assert request_2.url == 'https://example.com/3'
681682

682683
# Clean up
683684
await rq_1.drop()

0 commit comments

Comments
 (0)