Skip to content

Commit 851ca51

Browse files
committed
update test docs
1 parent b91ef31 commit 851ca51

File tree

1 file changed

+12
-13
lines changed

1 file changed

+12
-13
lines changed

tests/unit/crawlers/_basic/test_basic_crawler.py

Lines changed: 12 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1826,25 +1826,24 @@ async def handler(_: BasicCrawlingContext) -> None:
18261826

18271827

18281828
async def test_protect_request_in_run_handlers() -> None:
1829-
"""Test that session and request in crawling context are protected in run handlers."""
1829+
"""Test that request in crawling context are protected in run handlers."""
18301830
request_queue = await RequestQueue.open(name='state-test')
18311831

1832-
async with SessionPool(max_pool_size=1) as session_pool:
1833-
request = Request.from_url('https://test.url/', user_data={'request_state': ['initial']})
1832+
request = Request.from_url('https://test.url/', user_data={'request_state': ['initial']})
18341833

1835-
crawler = BasicCrawler(session_pool=session_pool, request_manager=request_queue, max_request_retries=0)
1834+
crawler = BasicCrawler(request_manager=request_queue, max_request_retries=0)
18361835

1837-
@crawler.router.default_handler
1838-
async def handler(context: BasicCrawlingContext) -> None:
1839-
if isinstance(context.request.user_data['request_state'], list):
1840-
context.request.user_data['request_state'].append('modified')
1841-
raise ValueError('Simulated error after modifying request and session')
1836+
@crawler.router.default_handler
1837+
async def handler(context: BasicCrawlingContext) -> None:
1838+
if isinstance(context.request.user_data['request_state'], list):
1839+
context.request.user_data['request_state'].append('modified')
1840+
raise ValueError('Simulated error after modifying request')
18421841

1843-
await crawler.run([request])
1842+
await crawler.run([request])
18441843

1845-
check_request = await request_queue.get_request(request.unique_key)
1846-
assert check_request is not None
1847-
assert check_request.user_data['request_state'] == ['initial']
1844+
check_request = await request_queue.get_request(request.unique_key)
1845+
assert check_request is not None
1846+
assert check_request.user_data['request_state'] == ['initial']
18481847

18491848
await request_queue.drop()
18501849

0 commit comments

Comments
 (0)