Improve memory clients creation

Author: vdusek

src/crawlee/storage_clients/_file_system/_dataset_client.py

@@ -113,7 +113,7 @@ async def open(
             ValueError: If a dataset with the specified ID is not found, if metadata is invalid,
                 or if both name and alias are provided.
         """
-        # Validate parameters
+        # Validate input parameters.
         specified_params = sum(1 for param in [id, name, alias] if param is not None)
         if specified_params > 1:
             raise ValueError('Only one of "id", "name", or "alias" can be specified, not multiple.')
@@ -174,9 +174,6 @@ async def open(
                 except ValidationError as exc:
                     raise ValueError(f'Invalid metadata file for dataset "{name or alias}"') from exc
 
-                # Update metadata name to match the resolution.
-                metadata.name = name
-
                 client = cls(
                     metadata=metadata,
                     path_to_dataset=path_to_dataset,

src/crawlee/storage_clients/_file_system/_key_value_store_client.py

@@ -112,9 +112,10 @@ async def open(
             ValueError: If a store with the specified ID is not found, if metadata is invalid,
                 or if both name and alias are provided.
         """
-        # Validate parameters - exactly one of name or alias should be provided (or neither for default)
-        if name is not None and alias is not None:
-            raise ValueError('Cannot specify both name and alias parameters')
+        # Validate input parameters.
+        specified_params = sum(1 for param in [id, name, alias] if param is not None)
+        if specified_params > 1:
+            raise ValueError('Only one of "id", "name", or "alias" can be specified, not multiple.')
 
         kvs_base_path = Path(configuration.storage_dir) / cls._STORAGE_SUBDIR
 
@@ -172,9 +173,6 @@ async def open(
                 except ValidationError as exc:
                     raise ValueError(f'Invalid metadata file for key-value store "{name or alias}"') from exc
 
-                # Update metadata name to match the resolution.
-                metadata.name = name
-
                 client = cls(
                     metadata=metadata,
                     path_to_kvs=path_to_kvs,

src/crawlee/storage_clients/_file_system/_request_queue_client.py

@@ -164,9 +164,10 @@ async def open(
             ValueError: If a queue with the specified ID is not found, if metadata is invalid,
                 or if both name and alias are provided.
         """
-        # Validate parameters - exactly one of name or alias should be provided (or neither for default)
-        if name is not None and alias is not None:
-            raise ValueError('Cannot specify both name and alias parameters')
+        # Validate input parameters.
+        specified_params = sum(1 for param in [id, name, alias] if param is not None)
+        if specified_params > 1:
+            raise ValueError('Only one of "id", "name", or "alias" can be specified, not multiple.')
 
         rq_base_path = Path(configuration.storage_dir) / cls._STORAGE_SUBDIR
 
@@ -227,9 +228,6 @@ async def open(
                 except ValidationError as exc:
                     raise ValueError(f'Invalid metadata file for request queue "{name or alias}"') from exc
 
-                # Update metadata name to match the resolution.
-                metadata.name = name
-
                 client = cls(
                     metadata=metadata,
                     path_to_rq=path_to_rq,

src/crawlee/storage_clients/_memory/_dataset_client.py

@@ -72,28 +72,18 @@ async def open(
         Raises:
             ValueError: If both name and alias are provided, or if neither id, name, nor alias is provided.
         """
-        # Validate parameters - exactly one of name or alias should be provided (or neither for default)
-        if name is not None and alias is not None:
-            raise ValueError('Cannot specify both name and alias parameters')
-
-        # Determine the actual name to use in metadata
-        if alias is not None:
-            # For alias storages, metadata.name should be None (unnamed storage)
-            actual_name = None
-        elif name is not None:
-            # For named storages, use the provided name
-            actual_name = name
-        else:
-            # For default storage (no name or alias), use None
-            actual_name = None
+        # Validate input parameters.
+        specified_params = sum(1 for param in [id, name, alias] if param is not None)
+        if specified_params > 1:
+            raise ValueError('Only one of "id", "name", or "alias" can be specified, not multiple.')
 
         # Create a new dataset
         dataset_id = id or crypto_random_object_id()
         now = datetime.now(timezone.utc)
 
         metadata = DatasetMetadata(
             id=dataset_id,
-            name=actual_name,
+            name=name,
             created_at=now,
             accessed_at=now,
             modified_at=now,

src/crawlee/storage_clients/_memory/_key_value_store_client.py

@@ -70,28 +70,18 @@ async def open(
         Raises:
             ValueError: If both name and alias are provided.
         """
-        # Validate parameters - exactly one of name or alias should be provided (or neither for default)
-        if name is not None and alias is not None:
-            raise ValueError('Cannot specify both name and alias parameters')
-
-        # Determine the actual name to use in metadata
-        if alias is not None:
-            # For alias storages, metadata.name should be None (unnamed storage)
-            actual_name = None
-        elif name is not None:
-            # For named storages, use the provided name
-            actual_name = name
-        else:
-            # For default storage (no name or alias), use None
-            actual_name = None
+        # Validate input parameters.
+        specified_params = sum(1 for param in [id, name, alias] if param is not None)
+        if specified_params > 1:
+            raise ValueError('Only one of "id", "name", or "alias" can be specified, not multiple.')
 
         # Create a new key-value store
         store_id = id or crypto_random_object_id()
         now = datetime.now(timezone.utc)
 
         metadata = KeyValueStoreMetadata(
             id=store_id,
-            name=actual_name,
+            name=name,
             created_at=now,
             accessed_at=now,
             modified_at=now,

src/crawlee/storage_clients/_memory/_request_queue_client.py

@@ -82,28 +82,18 @@ async def open(
         Raises:
             ValueError: If both name and alias are provided.
         """
-        # Validate parameters - exactly one of name or alias should be provided (or neither for default)
-        if name is not None and alias is not None:
-            raise ValueError('Cannot specify both name and alias parameters')
-
-        # Determine the actual name to use in metadata
-        if alias is not None:
-            # For alias storages, metadata.name should be None (unnamed storage)
-            actual_name = None
-        elif name is not None:
-            # For named storages, use the provided name
-            actual_name = name
-        else:
-            # For default storage (no name or alias), use None
-            actual_name = None
+        # Validate input parameters.
+        specified_params = sum(1 for param in [id, name, alias] if param is not None)
+        if specified_params > 1:
+            raise ValueError('Only one of "id", "name", or "alias" can be specified, not multiple.')
 
         # Create a new queue
         queue_id = id or crypto_random_object_id()
         now = datetime.now(timezone.utc)
 
         metadata = RequestQueueMetadata(
             id=queue_id,
-            name=actual_name,
+            name=name,
             created_at=now,
             accessed_at=now,
             modified_at=now,