address some changes in tests

Author: vdusek

tests/unit/conftest.py

@@ -66,7 +66,7 @@ def memory_storage_client(tmp_path: Path) -> MemoryStorageClient:
     return MemoryStorageClient(
         write_metadata=True,
         persist_storage=True,
-        crawlee_storage_dir=str(tmp_path),  # type: ignore[call-arg]
+        storage_dir=str(tmp_path),
     )
 
 

tests/unit/test_configuration.py

@@ -1,4 +1,4 @@
-# TODO: type ignores and crawlee_storage_dir
+# TODO: Update crawlee_storage_dir args once the Pydantic bug is fixed
 # https://github.com/apify/crawlee-python/issues/146
 
 from __future__ import annotations
@@ -13,6 +13,8 @@
 if TYPE_CHECKING:
     from pathlib import Path
 
+    from yarl import URL
+
 
 def test_global_configuration_works() -> None:
     assert (
@@ -23,11 +25,11 @@ def test_global_configuration_works() -> None:
     )
 
 
-async def test_storage_not_persisted_when_disabled(tmp_path: Path) -> None:
+async def test_storage_not_persisted_when_disabled(tmp_path: Path, httpbin: URL) -> None:
     config = Configuration(
         persist_storage=False,
         write_metadata=False,
-        crawlee_storage_dir=str(tmp_path),  # type: ignore
+        crawlee_storage_dir=str(tmp_path),  # type: ignore[call-arg]
     )
     storage_client = MemoryStorageClient(config)
     set_storage_client(storage_client, force=True)
@@ -38,18 +40,18 @@ async def test_storage_not_persisted_when_disabled(tmp_path: Path) -> None:
     async def default_handler(context: HttpCrawlingContext) -> None:
         await context.push_data({'url': context.request.url})
 
-    await crawler.run(['https://crawlee.dev'])
+    await crawler.run([str(httpbin)])
 
     # Verify that no files were created in the storage directory.
     content = list(tmp_path.iterdir())
     assert content == [], 'Expected the storage directory to be empty, but it is not.'
 
 
-async def test_storage_persisted_when_enabled(tmp_path: Path) -> None:
+async def test_storage_persisted_when_enabled(tmp_path: Path, httpbin: URL) -> None:
     config = Configuration(
         persist_storage=True,
         write_metadata=True,
-        crawlee_storage_dir=str(tmp_path),  # type: ignore
+        crawlee_storage_dir=str(tmp_path),  # type: ignore[call-arg]
     )
     storage_client = MemoryStorageClient(config)
     set_storage_client(storage_client, force=True)
@@ -60,7 +62,7 @@ async def test_storage_persisted_when_enabled(tmp_path: Path) -> None:
     async def default_handler(context: HttpCrawlingContext) -> None:
         await context.push_data({'url': context.request.url})
 
-    await crawler.run(['https://crawlee.dev'])
+    await crawler.run([str(httpbin)])
 
     # Verify that files were created in the storage directory.
     content = list(tmp_path.iterdir())