test: fix flaky tests

those were failing almost always locally on faster machines like mb m4 pro

Author: B4nan

package.json

@@ -82,7 +82,7 @@
         "@types/semver": "^7.3.12",
         "@types/stream-json": "^1.7.2",
         "@types/yargs": "^17.0.26",
-        "@vitest/coverage-v8": "^4.0.1",
+        "@vitest/coverage-v8": "^4.0.16",
         "apify": "*",
         "apify-node-curl-impersonate": "^1.0.15",
         "basic-auth-parser": "^0.0.2",
@@ -113,7 +113,7 @@
         "turbo": "^2.1.0",
         "typescript": "^5.7.3",
         "typescript-eslint": "^8.28.0",
-        "vitest": "^4.0.1"
+        "vitest": "^4.0.16"
     },
     "packageManager": "yarn@4.10.3",
     "volta": {

test/core/crawlers/basic_crawler.test.ts

@@ -965,11 +965,11 @@ describe('BasicCrawler', () => {
         requestQueue.fetchNextRequest = async () => queue.pop()!;
         requestQueue.isEmpty = async () => Promise.resolve(!queue.length);
 
-        setTimeout(() => queue.push(request0), 10);
-        setTimeout(() => queue.push(request1), 100);
+        setTimeout(() => queue.push(request0), 100);
+        setTimeout(() => queue.push(request1), 250);
         setTimeout(() => {
             isFinished = true;
-        }, 150);
+        }, 600);
 
         await basicCrawler.run();
 
@@ -1016,11 +1016,11 @@ describe('BasicCrawler', () => {
         requestQueue.fetchNextRequest = async () => Promise.resolve(queue.pop()!);
         requestQueue.isEmpty = async () => Promise.resolve(!queue.length);
 
-        setTimeout(() => queue.push(request0), 10);
-        setTimeout(() => queue.push(request1), 100);
+        setTimeout(() => queue.push(request0), 100);
+        setTimeout(() => queue.push(request1), 250);
         setTimeout(() => {
             void basicCrawler.teardown();
-        }, 300);
+        }, 650);
 
         await basicCrawler.run();
 

test/core/puppeteer_utils.test.ts

@@ -242,7 +242,7 @@ describe('puppeteerUtils', () => {
                     urlPatterns: ['.css'],
                 });
                 page.on('response', (response) => loadedUrls.push(response.url()));
-                await page.goto(`${serverAddress}/special/resources`, { waitUntil: 'load' });
+                await page.goto(`${serverAddress}/special/resources`, { waitUntil: 'networkidle0' });
 
                 expect(loadedUrls).toEqual(
                     expect.arrayContaining([

test/utils/fixtures/child.js

@@ -1,4 +1,4 @@
 // dummy script for testing ps-tree.ts
 setTimeout(() => {
     /* Does nothing, but prevents exit */
-}, 1000);
+}, 5000);

test/utils/psTree.test.ts

@@ -8,19 +8,34 @@ const scripts = {
     child: path.join(__dirname, 'fixtures', 'child.js'),
 };
 
+// Helper to poll for a condition on process tree
+async function waitForCondition(
+    pid: number,
+    condition: (children: any[]) => boolean,
+    maxWaitMs = 3000,
+): Promise<any[]> {
+    const startTime = Date.now();
+    while (Date.now() - startTime < maxWaitMs) {
+        const children = await psTree(pid);
+        if (condition(children)) {
+            return children;
+        }
+        await new Promise((resolve) => setTimeout(resolve, 100));
+    }
+    return psTree(pid); // Final attempt
+}
+
 describe('psTree()', () => {
     test('Spawn a Parent process which has Ten Child Processes', async () => {
         const parent = exec(`node ${scripts.parent}`);
 
-        // Wait for the child process(es) to spawn.
-        await new Promise((resolve) => setTimeout(resolve, 500));
-
-        const children = await psTree(parent.pid!);
+        // Poll until child processes are detected
+        const children = await waitForCondition(parent.pid!, (c) => c.length > 0);
 
         expect(children.length).toBeGreaterThan(0);
 
-        // Allow time for the processes to be terminated.
-        await new Promise((resolve) => setTimeout(resolve, 2000));
+        // Poll until processes terminate
+        await waitForCondition(parent.pid!, (c) => c.length === 0, 10000);
 
         const postKillChildren = await psTree(parent.pid!);
 
@@ -30,17 +45,17 @@ describe('psTree()', () => {
     test('Includes itself if includeRoot is true', async () => {
         const parent = exec(`node ${scripts.parent}`);
 
-        // Wait for the child process(es) to spawn.
-        await new Promise((resolve) => setTimeout(resolve, 500));
-
-        const processes = await psTree(parent.pid!, true);
+        // Poll until processes are detected (parent + at least one child)
+        await waitForCondition(parent.pid!, (c) => c.length > 1, 3000);
 
-        const parentProcess = processes.find((process) => Number.parseInt(process.PID, 10) === parent.pid!);
+        // Get processes with includeRoot after waiting
+        const processesWithRoot = await psTree(parent.pid!, true);
+        const parentProcess = processesWithRoot.find((process) => Number.parseInt(process.PID, 10) === parent.pid!);
 
         expect(parentProcess).toBeDefined();
 
-        // Allow time for the processes to be terminated.
-        await new Promise((resolve) => setTimeout(resolve, 2000));
+        // Poll until processes terminate
+        await waitForCondition(parent.pid!, (c) => c.length === 0, 10000);
 
         const postKillChildren = await psTree(parent.pid!);