Consider avoiding adding suffixes to files in MemoryStorageClient

[janbuchar]

There is currently an automagic mechanism that stores binary files with a ".bin" extension and text files with a ".txt" extension. Is the comfort for Windows users worth the complexity?

[janbuchar]

This surprised us in apify/crawlee-python#572

[vladfrangu]

If memory serves me right I did this to make it similar to what the API does. That said my memory is rusty so take with a pinch of salt

[B4nan]

I also believe this is about behaving the same as the platform/API, and we surely want this to behave the same as the apify client.

[janbuchar]

Could you elaborate what the API does? 🙂 I tried adding a key with no content type and it got stored just like that, no extension out of nowhere

[vladfrangu]

Can you check what the platform does when downloading such a file?

[janbuchar]

If you mean this,

it downloads the file with no suffix

[vladfrangu]

hmm, then it might've just been a port from old-but-still-alive local storage 😓

[B4nan]

Better to open this on slack, i am not opposed to changing this, but it would be great to first understand why it was like that (and I doubt anyone from our team will know).

[vladfrangu]

4 years ago 🥲