-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Avoid passing unproxied request separately to internal methods #3526
Copy link
Copy link
Open
Labels
t-toolingIssues with this label are in the ownership of the tooling team.Issues with this label are in the ownership of the tooling team.
Description
After #3381, when skipNavigation is used, crawlingContext.request is a Proxy that throws on loadedUrl access. Internal methods like markRequestAsHandled destructure the request object, which triggers this trap, so we currently work around it by passing the original unproxied request as a separate parameter.
Instead, these internal methods should be fixed to not blindly destructure (or otherwise access loadedUrl on) the request, so that they work correctly with the proxied request and the separate parameter hack can be removed.
This might also be partly addressed by #3075 - the request queue methods may not require the whole Request after that.
Ref: #3381 (comment)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
t-toolingIssues with this label are in the ownership of the tooling team.Issues with this label are in the ownership of the tooling team.
Type
Fields
Give feedbackNo fields configured for issues without a type.