chore: apply automatic formatting (clippy)

Author: barjin

impit/src/http3.rs

@@ -39,7 +39,7 @@ impl H3Engine {
         }
     }
 
-    pub async fn host_supports_h3(self: &mut Self, host: &String) -> bool {
+    pub async fn host_supports_h3(&mut self, host: &String) -> bool {
         if let Some(supports_h3) = self.h3_alt_svc.get(host) {
             return supports_h3.to_owned();
         }
@@ -74,7 +74,7 @@ impl H3Engine {
         dns_h3_support
     }
 
-    pub fn set_h3_support(self: &mut Self, host: &String, supports_h3: bool) {
+    pub fn set_h3_support(&mut self, host: &String, supports_h3: bool) {
         if self.h3_alt_svc.contains_key(host) {
             return;
         }

impit/src/http_headers/mod.rs

@@ -20,23 +20,23 @@ impl HttpHeaders {
     }
 }
 
-impl Into<HeaderMap> for HttpHeaders {
-    fn into(self) -> HeaderMap {
+impl From<HttpHeaders> for HeaderMap {
+    fn from(val: HttpHeaders) -> Self {
         let mut headers = HeaderMap::new();
 
-        let header_values = match self.context.browser {
+        let header_values = match val.context.browser {
             Some(Browser::Chrome) => statics::CHROME_HEADERS,
             Some(Browser::Firefox) => statics::FIREFOX_HEADERS,
             None => &[],
         };
 
-        let pseudo_headers_order: &[&str] = match self.context.browser {
+        let pseudo_headers_order: &[&str] = match val.context.browser {
             Some(Browser::Chrome) => statics::CHROME_PSEUDOHEADERS_ORDER.as_ref(),
             Some(Browser::Firefox) => statics::FIREFOX_PSEUDOHEADERS_ORDER.as_ref(),
             None => &[],
         };
 
-        if pseudo_headers_order.len() != 0 {
+        if !pseudo_headers_order.is_empty() {
             std::env::set_var(
                 "IMPIT_H2_PSEUDOHEADERS_ORDER",
                 pseudo_headers_order.join(","),
@@ -47,7 +47,7 @@ impl Into<HeaderMap> for HttpHeaders {
 
         // TODO: don't use HTTP2 headers for HTTP1.1
         for (name, impersonated_value) in header_values {
-            let value: &str = match self.context.custom_headers.get(*name) {
+            let value: &str = match val.context.custom_headers.get(*name) {
                 Some(custom_value) => {
                     used_custom_headers.push(name.to_string());
                     custom_value.as_str()
@@ -61,17 +61,14 @@ impl Into<HeaderMap> for HttpHeaders {
             );
         }
 
-        self.context
-            .custom_headers
-            .iter()
-            .for_each(|(name, value)| {
-                if !used_custom_headers.contains(name) {
-                    headers.append(
-                        HeaderName::from_str(name).unwrap(),
-                        HeaderValue::from_str(value).unwrap(),
-                    );
-                }
-            });
+        val.context.custom_headers.iter().for_each(|(name, value)| {
+            if !used_custom_headers.contains(name) {
+                headers.append(
+                    HeaderName::from_str(name).unwrap(),
+                    HeaderValue::from_str(value).unwrap(),
+                );
+            }
+        });
 
         headers
     }

impit/src/http_headers/statics.rs

@@ -2,7 +2,7 @@
 // Note that not all requests are made the same:
 //  - on forced (Ctrl+R) reloads, Chrome sets Cache-Control: max-age=0
 //  - when the URL is in the address bar (but not submitted yet), Chrome sets `Purpose: prefetch` and `Sec-Purpose: prefetch`
-pub static CHROME_HEADERS: &'static [(&'static str, &'static str)] = &[
+pub static CHROME_HEADERS: &[(&str, &str)] = &[
     ("sec-ch-ua", "\"Google Chrome\";v=\"125\", \"Chromium\";v=\"125\", \"Not.A/Brand\";v=\"24\""),
     ("sec-ch-ua-mobile", "?0"),
     ("sec-ch-ua-platform", "Linux"),
@@ -17,7 +17,7 @@ pub static CHROME_HEADERS: &'static [(&'static str, &'static str)] = &[
     ("accept-language", "en-US,en;q=0.9"),
 ];
 
-pub static CHROME_PSEUDOHEADERS_ORDER: [&'static str; 6] = [
+pub static CHROME_PSEUDOHEADERS_ORDER: [&str; 6] = [
     ":method",
     ":authority",
     ":scheme",
@@ -26,7 +26,7 @@ pub static CHROME_PSEUDOHEADERS_ORDER: [&'static str; 6] = [
     ":status",
 ];
 
-pub static FIREFOX_HEADERS: &'static [(&'static str, &'static str)] = &[
+pub static FIREFOX_HEADERS: &[(&str, &str)] = &[
     ("User-Agent", "Mozilla/5.0 (X11; Linux x86_64; rv:128.0) Gecko/20100101 Firefox/128.0"),
     ("Accept", "text/html,application/xhtml+xml,application/xml;q=0.9,image/avif,image/webp,image/png,image/svg+xml,*/*;q=0.8"),
     ("Accept-Language", "en,cs;q=0.7,en-US;q=0.3"),
@@ -40,7 +40,7 @@ pub static FIREFOX_HEADERS: &'static [(&'static str, &'static str)] = &[
     ("Priority", "u=0, i"),
 ];
 
-pub static FIREFOX_PSEUDOHEADERS_ORDER: [&'static str; 6] = [
+pub static FIREFOX_PSEUDOHEADERS_ORDER: [&str; 6] = [
     ":method",
     ":path",
     ":authority",

impit/src/impit.rs

@@ -197,7 +197,7 @@ impl Impit {
             client = client.http3_prior_knowledge();
         }
 
-        if config.proxy_url.len() > 0 {
+        if !config.proxy_url.is_empty() {
             client = client.proxy(
                 reqwest::Proxy::all(&config.proxy_url)
                     .expect("The proxy_url option should be a valid URL."),
@@ -252,20 +252,20 @@ impl Impit {
 
         let protocol = url.scheme();
 
-        return match protocol {
+        match protocol {
             "http" => Ok(url),
             "https" => Ok(url),
             _ => Err(ErrorType::UrlProtocolError),
-        };
+        }
     }
 
-    async fn should_use_h3(self: &mut Self, host: &String) -> bool {
+    async fn should_use_h3(&mut self, host: &String) -> bool {
         if self.config.max_http_version < Version::HTTP_3 {
             debug!("HTTP/3 is disabled, falling back to TCP-based requests.");
             return false;
         }
 
-        if let None = &self.h3_engine {
+        if self.h3_engine.is_none() {
             self.h3_engine = Some(H3Engine::init().await);
         }
 

impit/src/request.rs

@@ -5,7 +5,7 @@ use std::{collections::HashMap, time::Duration};
 /// Unlike the [`ImpitBuilder`](crate::impit::ImpitBuilder) struct, these options are specific to a single request.
 ///
 /// Used by the [`Impit`](crate::impit::Impit) struct's methods.
-#[derive(Debug, Clone)]
+#[derive(Debug, Clone, Default)]
 pub struct RequestOptions {
     /// A `HashMap` that holds custom HTTP headers. These are added to the default headers and should never overwrite them.
     pub headers: HashMap<String, String>,
@@ -16,13 +16,3 @@ pub struct RequestOptions {
     /// If [`ImpitBuilder::with_http3`](crate::impit::ImpitBuilder::with_http3) wasn't called, this option will cause [`ErrorType::Http3Disabled`](crate::impit::ErrorType::Http3Disabled) errors.
     pub http3_prior_knowledge: bool,
 }
-
-impl Default for RequestOptions {
-    fn default() -> Self {
-        RequestOptions {
-            headers: HashMap::new(),
-            timeout: None,
-            http3_prior_knowledge: false,
-        }
-    }
-}

impit/src/response_parsing/mod.rs

@@ -93,15 +93,15 @@ pub fn decode(bytes: &Vec<u8>, encoding_prior_knowledge: Option<encoding::Encodi
 
     if let Some(enc) = encoding_prior_knowledge {
         encoding = enc;
-    } else if let Some(enc) = bom_sniffing(&bytes) {
+    } else if let Some(enc) = bom_sniffing(bytes) {
         encoding = enc;
-    } else if let Some(enc) = prescan_bytestream(&bytes) {
+    } else if let Some(enc) = prescan_bytestream(bytes) {
         encoding = enc;
     }
 
-    return encoding
-        .decode(&bytes, encoding::DecoderTrap::Strict)
-        .unwrap();
+    encoding
+        .decode(bytes, encoding::DecoderTrap::Strict)
+        .unwrap()
 }
 
 /// A struct that represents the contents of the `Content-Type` header.
@@ -122,7 +122,7 @@ impl ContentType {
     pub fn from(content_type: &str) -> Result<Self, ()> {
         let parts: Vec<&str> = content_type.split("charset=").collect();
 
-        if parts.len() != 2 || parts[1].len() == 0 {
+        if parts.len() != 2 || parts[1].is_empty() {
             return Err(());
         }
 
@@ -132,8 +132,8 @@ impl ContentType {
     }
 }
 
-impl Into<Option<encoding::EncodingRef>> for ContentType {
-    fn into(self) -> Option<encoding::EncodingRef> {
-        encoding::label::encoding_from_whatwg_label(self.charset.as_str())
+impl From<ContentType> for Option<encoding::EncodingRef> {
+    fn from(val: ContentType) -> Self {
+        encoding::label::encoding_from_whatwg_label(val.charset.as_str())
     }
 }

impit/src/tls/mod.rs

@@ -79,18 +79,15 @@ impl TlsConfigBuilder {
                     .with_browser_emulator(&rustls_browser)
                     .build();
 
-                match browser {
-                    Browser::Firefox => {
-                        crypto_provider.kx_groups = vec![
-                            X25519,
-                            SECP256R1,
-                            SECP384R1,
-                            // TODO : add SECPR521R1
-                            &ffdhe::FFDHE2048_KX_GROUP,
-                            &ffdhe::FFDHE3072_KX_GROUP,
-                        ];
-                    }
-                    _ => {}
+                if browser == Browser::Firefox {
+                    crypto_provider.kx_groups = vec![
+                        X25519,
+                        SECP256R1,
+                        SECP384R1,
+                        // TODO : add SECPR521R1
+                        &ffdhe::FFDHE2048_KX_GROUP,
+                        &ffdhe::FFDHE3072_KX_GROUP,
+                    ];
                 }
 
                 let mut config: rustls::ClientConfig =