App creation fails without API Products (#809)

* App creation fails without API Products caused by features.keymanagement.disable.unbounded.permissions flag
* Update minimum version of apigee-client-php

Author: phdhiren

.github/workflows/php.yml

@@ -63,17 +63,17 @@ jobs:
       id: composercache
       run: |
         cd drupal
-        echo "::set-output name=dir::$(composer config cache-files-dir)"
+        echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT
 
     - name: Cache composer dependencies
-      uses: actions/cache@v2
+      uses: actions/cache@v3
       with:
         path: ${{ steps.composercache.outputs.dir }}
         key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}
         restore-keys: ${{ runner.os }}-composer-
 
     - name: Checkout apigee_edge module
-      uses: actions/checkout@v3.0.0
+      uses: actions/checkout@v3
       with:
         path: drupal/modules/contrib/apigee_edge
 

composer.json

@@ -6,7 +6,7 @@
     "require": {
         "php": "^7.4 || ^8.0",
         "ext-json": "*",
-        "apigee/apigee-client-php": "^2.0.16",
+        "apigee/apigee-client-php": "^2.0.19",
         "drupal/core": "^9.4",
         "drupal/entity": "^1.0",
         "drupal/key": "^1.8",

src/Entity/App.php

@@ -458,4 +458,11 @@ public static function uniqueIdProperties(): array {
     return array_merge(parent::uniqueIdProperties(), ['appId']);
   }
 
+  /**
+   * {@inheritdoc}
+   */
+  public function setInitialApiProducts(array $initialApiProducts): void {
+    $this->decorated->setInitialApiProducts($initialApiProducts);
+  }
+
 }

src/Entity/Form/AppForm.php

@@ -124,6 +124,19 @@ public function buildEntity(array $form, FormStateInterface $form_state) {
     // Set the owner of the app. Without this an app can not be saved.
     // @see \Drupal\apigee_edge\Entity\Controller\DeveloperAppEdgeEntityControllerProxy::create()
     $entity->setAppOwner($form_state->getValue('owner'));
+
+    // Set the api_products while creating App initially.
+    if ($form_state->getValue('api_products')) {
+      if (is_array($form_state->getValue('api_products'))) {
+        // API Products are multiselect.
+        $entity->setInitialApiProducts(array_keys(array_filter($form_state->getValue('api_products'))));
+      }
+      else {
+        // API Products are single select or radio.
+        $entity->setInitialApiProducts([$form_state->getValue('api_products')]);
+      }
+    }
+
     return $entity;
   }
 

tests/src/Functional/DeveloperAppUITestTrait.php

@@ -296,6 +296,7 @@ protected function assertAppCreationWithProduct(array $products = [], bool $mult
       'name' => $name,
       'displayName[0][value]' => $name,
     ];
+
     if (count($products) === 1) {
       $formdata['api_products'] = reset($products)->getName();
     }