Merge pull request #323 from cnovak/320-missing-splat

#320 Fix ApiProduct Entity setProxies() runtime error

Author: shadcn

src/Entity/ApiProduct.php

@@ -109,7 +109,7 @@ public function getProxies(): array {
    * {@inheritdoc}
    */
   public function setProxies(string ...$proxy): void {
-    $this->decorated->setProxies($proxy);
+    $this->decorated->setProxies(...$proxy);
   }
 
   /**

tests/src/Unit/Entity/ApiProductTest.php

@@ -0,0 +1,77 @@
+<?php
+
+/**
+ * Copyright 2020 Google Inc.
+ *
+ * This program is free software; you can redistribute it and/or modify it under
+ * the terms of the GNU General Public License version 2 as published by the
+ * Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY
+ * or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public
+ * License for more details.
+ *
+ * You should have received a copy of the GNU General Public License along
+ * with this program; if not, write to the Free Software Foundation, Inc., 51
+ * Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
+ */
+
+use Drupal\apigee_edge\Entity\ApiProduct;
+use Drupal\Tests\UnitTestCase;
+
+/**
+ * Test ApiProductTest class.
+ *
+ * @group apigee_edge
+ */
+class ApiProductTest extends UnitTestCase {
+
+  /**
+   * The API Product under test.
+   *
+   * @var \Drupal\apigee_edge\Entity\ApiProduct
+   */
+  private $apiProduct;
+
+  /**
+   * {@inheritdoc}
+   */
+  protected function setUp() {
+    parent::setUp();
+    $this->apiProduct = new ApiProduct([]);
+  }
+
+  /**
+   * Test setting proxies.
+   */
+  public function testSetProxies() {
+    $proxies_expected = ['proxy1', 'proxy2'];
+    $this->apiProduct->setProxies(...$proxies_expected);
+    $proxies_actual = $this->apiProduct->getProxies();
+    $this->assertArrayEquals($proxies_expected, $proxies_actual);
+
+  }
+
+  /**
+   * Test setting scopes.
+   */
+  public function testSetScopes() {
+    $scopes_expected = ['scope1', 'scope2'];
+    $this->apiProduct->setScopes(...$scopes_expected);
+    $scopes_actual = $this->apiProduct->getScopes();
+    $this->assertArrayEquals($scopes_expected, $scopes_actual);
+
+  }
+
+  /**
+   * Test setting environments.
+   */
+  public function testSetEnvironments() {
+    $environments_expected = ['environment1', 'environment2'];
+    $this->apiProduct->setEnvironments(...$environments_expected);
+    $environments_actual = $this->apiProduct->getEnvironments();
+    $this->assertArrayEquals($environments_expected, $environments_actual);
+  }
+
+}