Merge pull request #293 from mxr576/issue/292

[#292] Fix Developer::hasCompany()

Author: arlina-espinoza

src/Entity/Developer.php

@@ -314,7 +314,7 @@ public function getCompanies(): array {
    * {@inheritdoc}
    */
   public function hasCompany(string $company_name): bool {
-    return $this->decorated->hasCompany($company_name);
+    return in_array($company_name, $this->getCompanies(), TRUE);
   }
 
   /**

tests/src/Functional/DeveloperTest.php

@@ -347,9 +347,10 @@ protected function developerCreateByAdminTest() {
   }
 
   /**
-   * Tests getCompanies() function of the developer entity.
+   * Tests getCompanies() and hasCompany() methods on the developer entity.
    *
    * @see \Drupal\apigee_edge\Entity\Developer::getCompanies()
+   * @see \Drupal\apigee_edge\Entity\Developer::hasCompany()
    */
   public function developerGetCompanyListTest() {
     // Create a new developer.
@@ -389,13 +390,15 @@ public function developerGetCompanyListTest() {
     /** @var \Drupal\apigee_edge\Entity\DeveloperInterface $developer */
     $developer = $this->developerStorage->loadMultiple()[$this->developer->id()];
     $this->assertContains($this->company->getName(), $developer->getCompanies());
+    self::assertTrue($developer->hasCompany($this->company->getName()));
 
     // Check the companies array if the developer is removed from the member
     // list.
     $company_membership_controller->removeMember($this->developer->getEmail());
     $developer_cache->removeEntities([$this->developer->id()]);
     $developer = $this->developerStorage->loadUnchanged($this->developer->id());
     $this->assertNotContains($this->company->getName(), $developer->getCompanies());
+    self::assertFalse($developer->hasCompany($this->company->getName()));
   }
 
 }