Fixes deprecations of renderPlain() & getName() (#1136)

Author: kedarkhaire

modules/apigee_edge_teams/apigee_edge_teams.services.yml

@@ -65,7 +65,7 @@ services:
 
   apigee_edge_teams.team_permissions:
     class: Drupal\apigee_edge_teams\TeamPermissionHandler
-    arguments: ['@module_handler', '@class_resolver', '@apigee_edge_teams.team_membership_manager', '@entity_type.manager']
+    arguments: ['@module_handler', '@class_resolver', '@apigee_edge_teams.team_membership_manager', '@entity_type.manager', '@extension.list.module']
     calls:
       - [setStringTranslation, ['@string_translation']]
 

modules/apigee_edge_teams/src/TeamPermissionHandler.php

@@ -24,6 +24,7 @@
 use Drupal\Core\Discovery\YamlDiscovery;
 use Drupal\Core\Entity\EntityTypeManagerInterface;
 use Drupal\Core\Extension\ModuleHandlerInterface;
+use Drupal\Core\Extension\ModuleExtensionList;
 use Drupal\Core\Session\AccountInterface;
 use Drupal\Core\StringTranslation\StringTranslationTrait;
 use Drupal\apigee_edge_teams\Entity\TeamInterface;
@@ -112,6 +113,13 @@ final class TeamPermissionHandler implements TeamPermissionHandlerInterface {
    */
   private $entityTypeManager;
 
+  /**
+   * The module extension list.
+   *
+   * @var \Drupal\Core\Extension\ModuleExtensionList
+   */
+  private $moduleExtensionList;
+
   /**
    * TeamPermissionHandler constructor.
    *
@@ -123,12 +131,15 @@ final class TeamPermissionHandler implements TeamPermissionHandlerInterface {
    *   The team membership manager service.
    * @param \Drupal\Core\Entity\EntityTypeManagerInterface $entity_type_manager
    *   The entity type manager.
+   * @param \Drupal\Core\Extension\ModuleExtensionList $module_extension_list
+   *   The module extension list.
    */
-  public function __construct(ModuleHandlerInterface $module_handler, ClassResolverInterface $class_resolver, TeamMembershipManagerInterface $team_membership_manager, EntityTypeManagerInterface $entity_type_manager) {
+  public function __construct(ModuleHandlerInterface $module_handler, ClassResolverInterface $class_resolver, TeamMembershipManagerInterface $team_membership_manager, EntityTypeManagerInterface $entity_type_manager, ModuleExtensionList $module_extension_list) {
     $this->moduleHandler = $module_handler;
     $this->classResolver = $class_resolver;
     $this->teamMembershipManager = $team_membership_manager;
     $this->entityTypeManager = $entity_type_manager;
+    $this->moduleExtensionList = $module_extension_list;
   }
 
   /**
@@ -299,7 +310,7 @@ protected function sortPermissions(array $all_permissions = []) {
   protected function getModuleNames(): array {
     $modules = [];
     foreach (array_keys($this->moduleHandler->getModuleList()) as $module) {
-      $modules[$module] = $this->moduleHandler->getName($module);
+      $modules[$module] = $this->moduleExtensionList->getName($module);
     }
     asort($modules);
     return $modules;

src/Entity/ListBuilder/AppListBuilder.php

@@ -290,7 +290,7 @@ protected function buildWarningRow(AppInterface $app, array &$rows) {
       $url = Url::fromUserInput($this->requestStack->getCurrentRequest()->getRequestUri(), $link_options);
       $link = Link::fromTextAndUrl($this->t('<span class="ui-icon-triangle-1-e ui-icon"></span><span class="text">Show details</span>'), $url);
       $build['warning-toggle'] = $link->toRenderable();
-      $rows[$info_row_css_id]['data']['status']['data'] = $this->renderer->renderPlain($build);
+      $rows[$info_row_css_id]['data']['status']['data'] = $this->renderer->renderInIsolation($build);
       $row['data']['info'] = [
         'colspan' => count($this->buildHeader()),
       ];