execute action in transaction and always rollback so that testing an action has no side effects

Author: chriskapp

src/Backend/Action/Action/Execute.php

@@ -20,6 +20,7 @@
 
 namespace Fusio\Impl\Backend\Action\Action;
 
+use Doctrine\DBAL\Connection;
 use Fusio\Engine\ActionInterface;
 use Fusio\Engine\ContextInterface;
 use Fusio\Engine\ParametersInterface;
@@ -31,6 +32,8 @@
 use PSX\Http\Environment\HttpResponseInterface;
 use PSX\Http\Response;
 use PSX\Http\Writer\WriterInterface;
+use stdClass;
+use Throwable;
 
 /**
  * Execute
@@ -39,14 +42,12 @@
  * @license http://www.apache.org/licenses/LICENSE-2.0
  * @link    https://www.fusio-project.org
  */
-class Execute implements ActionInterface
+readonly class Execute implements ActionInterface
 {
-    private Action\Executor $actionExecutorService;
     private Converter $exceptionConverter;
 
-    public function __construct(Action\Executor $actionExecutorService)
+    public function __construct(private Action\Executor $actionExecutorService, private Connection $connection)
     {
-        $this->actionExecutorService = $actionExecutorService;
         $this->exceptionConverter = new Converter(true);
     }
 
@@ -56,6 +57,8 @@ public function handle(RequestInterface $request, ParametersInterface $configura
 
         assert($body instanceof ActionExecuteRequest);
 
+        $this->connection->beginTransaction();
+
         try {
             $response = $this->actionExecutorService->execute(
                 $request->get('action_id'),
@@ -74,30 +77,34 @@ public function handle(RequestInterface $request, ParametersInterface $configura
                     $body = (string) $tempResponse->getBody();
                 }
 
-                return [
+                $return = [
                     'statusCode' => $response->getStatusCode(),
                     'headers' => $headers,
                     'body' => $body,
                 ];
             } else {
-                return [
+                $return = [
                     'statusCode' => 200,
-                    'headers' => new \stdClass(),
+                    'headers' => new stdClass(),
                     'body' => $response,
                 ];
             }
-        } catch (\Throwable $e) {
+        } catch (Throwable $e) {
             if ($e instanceof MessageException) {
                 $body = $e->getPayload();
             } else {
                 $body = $this->exceptionConverter->convert($e);
             }
 
-            return [
+            $return = [
                 'statusCode' => 500,
-                'headers' => new \stdClass(),
+                'headers' => new stdClass(),
                 'body' => $body,
             ];
         }
+
+        $this->connection->rollBack();
+
+        return $return;
     }
 }