Skip to content

Commit 16c8a84

Browse files
committed
refactor: remove WSL2-specific YubiKey code
Removes WSL2 detection and workarounds from yubikey.py to keep the codebase clean. WSL2 support was experimental and introduced complexity without a fully working solution for interactive PIN/touch prompts. Users on WSL2 should either: - Install pcscd (sudo dnf install pcsc-lite) for native Linux plugin support - Use Windows PowerShell directly for YubiKey operations All 101 tests pass. BREAKING CHANGE: WSL2 users previously relying on the experimental WSL2 support will need to use one of the alternative approaches above.
1 parent 6375454 commit 16c8a84

File tree

3 files changed

+117
-307
lines changed

3 files changed

+117
-307
lines changed

.github/workflows/test.yml

Lines changed: 24 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ on:
1212
- 'docs/**'
1313

1414
jobs:
15-
test-fedora:
16-
runs-on: fedora-latest
15+
test-linux:
16+
runs-on: ubuntu-latest
1717
strategy:
1818
matrix:
1919
python-version: ["3.9", "3.10", "3.11", "3.12"]
@@ -72,20 +72,16 @@ jobs:
7272

7373
- name: Check code formatting with black
7474
run: |
75+
black --version
7576
black --check src/ tests/
7677
7778
- name: Run linting with flake8
7879
run: |
7980
flake8 src/ tests/ --count --max-complexity=10 --statistics
8081
81-
- name: Run type checking with mypy
82-
continue-on-error: true
83-
run: |
84-
mypy src/
85-
8682
test-macos:
8783
runs-on: macos-latest
88-
needs: test-fedora
84+
needs: test-linux
8985
strategy:
9086
matrix:
9187
python-version: ["3.9", "3.10", "3.11", "3.12"]
@@ -144,13 +140,32 @@ jobs:
144140

145141
- name: Check code formatting with black
146142
run: |
143+
black --version
147144
black --check src/ tests/
148145
149146
- name: Run linting with flake8
150147
run: |
151148
flake8 src/ tests/ --count --max-complexity=10 --statistics
152149
150+
type-check:
151+
runs-on: ubuntu-latest
152+
needs: [test-linux, test-macos]
153+
continue-on-error: true
154+
155+
steps:
156+
- uses: actions/checkout@v4
157+
158+
- name: Set up Python
159+
uses: actions/setup-python@v5
160+
with:
161+
python-version: "3.12"
162+
163+
- name: Install dependencies
164+
run: |
165+
python -m pip install --upgrade pip
166+
pip install mypy
167+
pip install -e .
168+
153169
- name: Run type checking with mypy
154-
continue-on-error: true
155170
run: |
156171
mypy src/

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ dependencies = [
3838
dev = [
3939
"pytest>=7.0.0",
4040
"pytest-cov>=4.0.0",
41-
"black>=23.0.0",
41+
"black~=24.0",
4242
"flake8>=6.0.0",
4343
"mypy>=1.0.0",
4444
]

0 commit comments

Comments
 (0)