Merge pull request #3 from apivideo/delegated-upload-video-id

Allow delegated upload on existing video

Author: olivier-lando

README.md

@@ -86,10 +86,11 @@ The upload library is instanciated using an `options` object. Options to provide
 Using delegated upload tokens for authentication is best options when uploading from the client side. To know more about delegated upload token, read the dedicated article on api.video's blog: [Delegated Uploads](https://api.video/blog/tutorials/delegated-uploads).
 
 
-|                   Option name | Mandatory | Type   | Description       |
-| ----------------------------: | --------- | ------ | ----------------- |
-|                   uploadToken | **yes**   | string | your upload token |
-| _common options (see bellow)_ |           |        |                   |
+|                   Option name | Mandatory | Type   | Description             |
+| ----------------------------: | --------- | ------ | ----------------------- |
+|                   uploadToken | **yes**   | string | your upload token       |
+|                       videoId | no        | string | id of an existing video |
+| _common options (see bellow)_ |           |        |                         |
 
 ### Using an access token (discouraged):
 

dist/index.js

@@ -1,5 +1,6 @@
 interface OptionsWithUploadToken extends Options {
     uploadToken: string;
+    videoId?: string;
 }
 interface OptionsWithAccessToken extends Options {
     accessToken: string;

dist/src/index.d.ts

@@ -1,6 +1,6 @@
 {
   "name": "@api.video/video-uploader",
-  "version": "0.0.2",
+  "version": "0.0.3",
   "description": "api.video video uploader",
   "repository": {
     "type": "git",

package.json

@@ -1,5 +1,6 @@
 interface OptionsWithUploadToken extends Options {
     uploadToken: string;
+    videoId?: string;
 }
 interface OptionsWithAccessToken extends Options {
     accessToken: string;
@@ -47,6 +48,9 @@ export class VideoUploader {
 
         if (options.hasOwnProperty("uploadToken")) {
             const optionsWithUploadToken = options as OptionsWithUploadToken;
+            if (optionsWithUploadToken.videoId) {
+                this.videoId = optionsWithUploadToken.videoId;
+            }
             this.uploadEndpoint = `https://${apiHost}/upload?token=${optionsWithUploadToken.uploadToken}`;
 
         } else if (options.hasOwnProperty("accessToken")) {

src/index.ts

@@ -78,6 +78,29 @@ describe('Access token auth', () => {
     });
 });
 
+describe('Delegated upload', () => {
+    beforeEach(() => mock.setup());
+    afterEach(() => mock.teardown());
+
+    it('videoId is transmitted', (done) => {
+        const videoId = "9876";
+        const uploadToken = "1234";
+
+        const uploader = new VideoUploader({
+            file: new File([new ArrayBuffer(2000)], "filename"),
+            uploadToken,
+            videoId,
+        });
+
+        mock.post(`https://ws.api.video/upload?token=${uploadToken}`, (req, res) => {
+            expect(req.body().getAll("videoId")).to.be.eql([videoId]);
+            return res.status(201).body('{}');
+        });
+
+        uploader.upload().then(() => done());
+    });
+});
+
 describe('Progress listener', () => {
     beforeEach(() => mock.setup());
     afterEach(() => mock.teardown());