Skip to content

Commit 3abe913

Browse files
committed
<stop>-related bug fixed & tests amended & <Make> improved
1 parent 6e5ea9c commit 3abe913

File tree

6 files changed

+32
-22
lines changed

6 files changed

+32
-22
lines changed

APLSource/Admin/Make.aplf

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,23 @@
1-
Make flag;M;C;path;zipFilename;res;cfg;parms;F
2-
⍝ "Make" a new version of this project
1+
Make flag;M;C;path;zipFilename;res;parms;cfg
2+
⍝ "Make" a new version of this projects
33
:If flag
44
:If 0=⎕SE.⎕NC'MakeHelpers'
55
{}⎕SE.Tatin.LoadPackages'[tatin]MakeHelpers'⎕SE
66
:EndIf
77
M←⎕SE.MakeHelpers
8-
C←##.CiderConfig ⋄ F←M.##.FilesAndDirs
8+
C←##.CiderConfig
9+
⎕←'' ⋄ 0 0⍴⍞,0/⍞←'Pause sync services like Dropbox, Google Drive etc. in order to avoid FILE ACCESS errors. Press <enter> to continue '
10+
:If ⎕NULL≡cfg←M.EditPackageConfigFile C.HOME
11+
⎕←'Cancelled by user' ⋄ →0
12+
:EndIf
913
path←C.HOME,'/',C.CIDER.distributionFolder
10-
cfg←M.GetPackageCfg C.HOME
11-
cfg←M.EditVersion cfg
1214
M.RecreateFolder path
13-
M.RecreateFolder C.HOME,'/html'
1415
M.ConvertMarkdownToHtml5 C.HOME∘,¨'/docs/' '/html/'
15-
(C.HOME,'/html/')∘{⍺ ⎕NCOPY ⍵}¨F.ListFiles C.HOME,'/docs/*.png'
16+
(C.HOME,'/html/')∘{⍺ ⎕NCOPY⍠('IfExists' 'Replace')⊢⍵}¨M.##.F.ListFiles C.HOME,'/docs/*.png'
1617
path ⎕NCOPY C.HOME,'/html'
1718
parms←⎕SE.Tatin.CreateBuildParms C.HOME
18-
parms.targetPath←path
19+
parms.targetPath←C.CIDER.distributionFolder
1920
parms.version←cfg.version
2021
zipFilename←⎕SE.Tatin.BuildPackage parms
2122
⎕←'*** New version build successfully:',M.CR,' ',zipFilename
2223
:EndIf
23-
⍝Done
Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,16 @@
1-
r←Test_Misc_91(flag batchFlag);log;⎕TRAP;res;was
1+
r←Test_Misc_91(stop batchFlag);log;⎕TRAP;res;was
22
⍝ Exercise the function "Version"
33
⎕TRAP←(999 'C' '∘∘∘ ⍝ Deliberate error')(0 'N')
44
r←T._Failed
55

66
res←##.Tester2.Version
7-
→T.PassesIf 3=≢res
8-
→T.PassesIf'Tester2'≡1⊃res
9-
→T.PassesIf 0<≢2⊃res
10-
→T.PassesIf 0=≢3⊃res
7+
→T.PassesIf 1=≡res
8+
→T.PassesIf' '=1↑0⍴res
9+
→T.PassesIf∧/⎕D∊⍨{⍵↑⍨¯1+⌊/¯1+⍵⍳'-+'}res~'. '
1110

1211
was←⎕NS #.Tester2.TatinVars ⍝ Take a copy
1312
#.Tester2.⎕EX'TatinVars' ⍝ Delete it
1413
res←##.Tester2.Version ⍝ Run "Version"
15-
#.Tester2.TatinVars←⎕NS was ⍝ Restore initial "TatinVars"
16-
→T.PassesIf'Tester2'≡1⊃res
17-
→T.PassesIf 0=≢2⊃res ⍝ Because it could return a version number
18-
→T.PassesIf 0=≢3⊃res
14+
→T.PassesIf ''≡res
1915

2016
r←T._OK

APLSource/Tester2.aplc

Lines changed: 17 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
⎕IO←1 ⋄ ⎕ML←1
2121

2222

23-
∇ r←Version
23+
∇ r←Version;ref
2424
:Access Public shared
2525
⍝ Returns the version number from `TatinVars` if possible.
2626
⍝ See also `History`
@@ -31,14 +31,22 @@
3131
:Else
3232
⍝ When a script was not loaded with Tatin, there will be no namespace `TatinVars`.
3333
⍝ In such cases we cannot provide a version number, so we return just ''.
34-
r←''
34+
:If '#.Tester2.TestCases.'{⍺≡(≢⍺)↑⍵}⍕⎕THIS
35+
⍝ Runs in its own testcases, and therefore won't find the correct function without help
36+
ref←⊃⊃⎕CLASS ⎕THIS
37+
r←ref.Version
38+
:Else
39+
r←''
40+
:EndIf
3541
:EndIf
3642
3743

3844
∇ r←History
3945
:Access Public shared
4046
⍝ * 4.0.0 ⋄ 2025-04-03
4147
⍝ * Potenially breaking change: `Version` now returns the package config version number as a char vector
48+
⍝ * Packages updated
49+
⍝ * `Make` improved
4250
⍝ * 3.11.1 ⋄ 2024-12-30
4351
⍝ Bug fixes
4452
⍝ * In `Version`: if for some reason it cannot find `TatinVars` it should return
@@ -489,7 +497,7 @@
489497
:If ps.guiFlag
490498
_parms.ref2Gui←ps.ref2Gui←ps CreateGui ⍬
491499
:EndIf
492-
ShowLog{'--- Test framework "Tester2" version ',(2⊃⍵),' ----'}Version
500+
ShowLog{'--- Test framework "Tester2" version ',,' ----'}Version
493501
_ref←ProcessIniFiles _ref ps
494502
ps.returnCodes←⍬
495503
initialFlag←0 ⍝ Tells whether `Initial was executed or not
@@ -1308,6 +1316,9 @@
13081316
:If 0<ref.⎕NC'stopFlag'
13091317
:AndIf 0=ref.⎕NC'debugFlag'
13101318
flag2←ref.stopFlag
1319+
:ElseIf 0<ref.⎕NC'stop'
1320+
:AndIf 0=ref.⎕NC'debugFlag'
1321+
flag2←ref.stop
13111322
:Else
13121323
flag2←ref.debugFlag
13131324
:EndIf
@@ -1331,6 +1342,9 @@
13311342
:If 0<ref.⎕NC'stopFlag'
13321343
:AndIf 0=ref.⎕NC'debugFlag'
13331344
flag2←ref.stopFlag
1345+
:ElseIf 0<ref.⎕NC'stop'
1346+
:AndIf 0=ref.⎕NC'debugFlag'
1347+
flag2←ref.stop
13341348
:Else
13351349
flag2←ref.debugFlag
13361350
:EndIf

TestResults/CodeCoverage.cr

1.2 KB
Binary file not shown.

TestResults/CodeCoverage.profile

16 Bytes
Binary file not shown.

apl-package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,5 +19,5 @@
1919
source: "APLSource/Tester2.aplc",
2020
tags: "test,test-framework",
2121
userCommandScript: "",
22-
version: "3.11.1+52",
22+
version: "4.0.0+54",
2323
}

0 commit comments

Comments
 (0)