Better

Author: timfish

src/lib.rs

@@ -103,16 +103,15 @@ impl Instrumentor {
         version: &str,
         file_path: &PathBuf,
     ) -> InstrumentationVisitor {
-        let mut instrumentations = self
+        let instrumentations = self
             .instrumentations
             .iter()
             .filter(|instr| instr.matches(module_name, version, file_path))
             .cloned()
-            .collect::<Vec<_>>();
-
-        for instr in &mut instrumentations {
-            instr.set_module_version(version);
-        }
+            .map(|mut i| {
+                i.set_module_version(version);
+                i
+            });
 
         InstrumentationVisitor::new(instrumentations, &self.dc_module)
     }
@@ -125,10 +124,12 @@ pub struct InstrumentationVisitor {
 }
 
 impl InstrumentationVisitor {
-    fn new(instrumentations: Vec<Instrumentation>, dc_module: &str) -> Self
-where {
+    fn new<I>(instrumentations: I, dc_module: &str) -> Self
+    where
+        I: Iterator<Item = Instrumentation>,
+    {
         Self {
-            instrumentations,
+            instrumentations: instrumentations.collect(),
             dc_module: dc_module.to_string(),
         }
     }