-
Notifications
You must be signed in to change notification settings - Fork 2
feat: Add wasm module build #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
approved these changes
Jun 2, 2025
jsumners-nr
approved these changes
Jun 2, 2025
Contributor
jsumners-nr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
serdeandwasmfeatures so that consumers of the Rust library don't need to bring in all those dependencies if they don't need themtransformfunction toInstrumentationVisitor- this was moved from the test utils withunwrap()removedwasmmodule in the library that is only enabled with the wasm featurewasmmodule, add functions and types that are exposed from wasm via#[wasm_bindgen]InstrumentationVisitorlifetimes had to be removed because they're not supported across rust<->js boundarypackage.jsonYou can
npm install && npm run buildto build the module.You can run
npm testto run a single JavaScript test of the wasm and asserts the output matches what's expected.