feat: Allow unknown module type
#11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timfish
requested review from
AbhiPrasad,
bizob2828 and
jsumners-nr
and removed request for
bizob2828
bizob2828
reviewed
Jun 30, 2025
tests/wasm/tests.mjs
Outdated
|
|
||
| const original = await fs.readFile(path.join(import.meta.dirname, './testdata/original.mjs')) | ||
| const output = matchedTransforms.transform(original.toString('utf8'), true); | ||
| const output = matchedTransforms.transform(original.toString('utf8'), 'unknown'); |
Contributor
There was a problem hiding this comment.
shouldn't you still keep these tests to assert the boolean directly works?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously you needed to tell the JavaScript API whether the file you're transforming is ESM or CJS. While trying to use the published library in a bundler plugin, I found that you don't always know the module type and detecting this is non-trivial.
The swc
isModuletype actually has an unknown option where swc does module type detection. I have change the API so it's now possible to selectesm,cjsor alternativelyunknownand let swc detect it.