fix: remove track from transceiver if add request failed (livekit#1524)

Author: lukasIO

.changeset/wild-mails-change.md

@@ -0,0 +1,5 @@
+---
+"livekit-client": patch
+---
+
+fix: remove track from transceiver if add request failed

src/room/RTCEngine.ts

@@ -330,7 +330,7 @@ export default class RTCEngine extends (EventEmitter as new () => TypedEventEmit
         reject(
           new ConnectionError(
             'publication of local track timed out, no response from server',
-            ConnectionErrorReason.InternalError,
+            ConnectionErrorReason.Timeout,
           ),
         );
       }, 10_000);

src/room/errors.ts

@@ -16,6 +16,7 @@ export enum ConnectionErrorReason {
   InternalError,
   Cancelled,
   LeaveRequest,
+  Timeout,
 }
 
 export class ConnectionError extends LivekitError {

src/room/participant/LocalParticipant.ts

@@ -1142,11 +1142,32 @@ export default class LocalParticipant extends Participant {
     };
 
     let ti: TrackInfo;
+    const addTrackPromise = new Promise<TrackInfo>(async (resolve, reject) => {
+      try {
+        ti = await this.engine.addTrack(req);
+        resolve(ti);
+      } catch (err) {
+        if (track.sender && this.engine.pcManager?.publisher) {
+          this.engine.pcManager.publisher.removeTrack(track.sender);
+          await this.engine.negotiate().catch((negotiateErr) => {
+            this.log.error(
+              'failed to negotiate after removing track due to failed add track request',
+              {
+                ...this.logContext,
+                ...getLogContextFromTrack(track),
+                error: negotiateErr,
+              },
+            );
+          });
+        }
+        reject(err);
+      }
+    });
     if (this.enabledPublishVideoCodecs.length > 0) {
-      const rets = await Promise.all([this.engine.addTrack(req), negotiate()]);
+      const rets = await Promise.all([addTrackPromise, negotiate()]);
       ti = rets[0];
     } else {
-      ti = await this.engine.addTrack(req);
+      ti = await addTrackPromise;
       // server might not support the codec the client has requested, in that case, fallback
       // to a supported codec
       let primaryCodecMime: string | undefined;