musig: Take references to pub nonce and part sig in partial_verify

Author: stevenroose

examples/musig.rs

@@ -84,11 +84,11 @@ fn main() {
     let partial_sign2 = session.partial_sign(&secp, sec_nonce2, &keypair2, &musig_key_agg_cache);
 
     let is_partial_signature_valid =
-        session.partial_verify(&secp, &musig_key_agg_cache, partial_sign1, pub_nonce1, pubkey1);
+        session.partial_verify(&secp, &musig_key_agg_cache, &partial_sign1, &pub_nonce1, pubkey1);
     assert!(is_partial_signature_valid);
 
     let is_partial_signature_valid =
-        session.partial_verify(&secp, &musig_key_agg_cache, partial_sign2, pub_nonce2, pubkey2);
+        session.partial_verify(&secp, &musig_key_agg_cache, &partial_sign2, &pub_nonce2, pubkey2);
     assert!(is_partial_signature_valid);
 
     let partial_sigs = [partial_sign1, partial_sign2];

src/musig.rs

@@ -1226,8 +1226,8 @@ impl Session {
     /// assert!(session.partial_verify(
     ///     &secp,
     ///     &key_agg_cache,
-    ///     partial_sig1,
-    ///     pub_nonce1,
+    ///     &partial_sig1,
+    ///     &pub_nonce1,
     ///     pub_key1,
     /// ));
     /// # }
@@ -1236,8 +1236,8 @@ impl Session {
         &self,
         secp: &Secp256k1<C>,
         key_agg_cache: &KeyAggCache,
-        partial_sig: PartialSignature,
-        pub_nonce: PublicNonce,
+        partial_sig: &PartialSignature,
+        pub_nonce: &PublicNonce,
         pub_key: PublicKey,
     ) -> bool {
         let cx = secp.ctx().as_ptr();
@@ -1591,12 +1591,12 @@ mod tests {
         let partial_sign2 = session.partial_sign(&secp, sec_nonce2, &keypair2, &key_agg_cache);
 
         // Test partial signature verification
-        assert!(session.partial_verify(&secp, &key_agg_cache, partial_sign1, pub_nonce1, pubkey1));
-        assert!(session.partial_verify(&secp, &key_agg_cache, partial_sign2, pub_nonce2, pubkey2));
+        assert!(session.partial_verify(&secp, &key_agg_cache, &partial_sign1, &pub_nonce1, pubkey1));
+        assert!(session.partial_verify(&secp, &key_agg_cache, &partial_sign2, &pub_nonce2, pubkey2));
         // Test that they are invalid if you switch keys
-        assert!(!session.partial_verify(&secp, &key_agg_cache, partial_sign2, pub_nonce2, pubkey1));
-        assert!(!session.partial_verify(&secp, &key_agg_cache, partial_sign2, pub_nonce1, pubkey2));
-        assert!(!session.partial_verify(&secp, &key_agg_cache, partial_sign2, pub_nonce1, pubkey1));
+        assert!(!session.partial_verify(&secp, &key_agg_cache, &partial_sign2, &pub_nonce2, pubkey1));
+        assert!(!session.partial_verify(&secp, &key_agg_cache, &partial_sign2, &pub_nonce1, pubkey2));
+        assert!(!session.partial_verify(&secp, &key_agg_cache, &partial_sign2, &pub_nonce1, pubkey1));
 
         // Test PartialSignature serialization/deserialization
         let serialized_partial_sig = partial_sign1.serialize();