Skip to content

Commit 536e4cc

Browse files
Mauro Passerinoapojomovsky
authored andcommitted
Add logs on failed take response/request (irobot-ros#107)
1 parent 6d4a828 commit 536e4cc

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

rclcpp/src/rclcpp/client.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,10 @@ ClientBase::take_type_erased_response(void * response_out, rmw_request_id_t & re
7575
&request_header_out,
7676
response_out);
7777
if (RCL_RET_CLIENT_TAKE_FAILED == ret) {
78+
RCLCPP_ERROR(
79+
rclcpp::get_logger("rclcpp"),
80+
"Error in take_type_erased_response: RCL_RET_CLIENT_TAKE_FAILED. "
81+
"Service name: %s", get_service_name());
7882
return false;
7983
} else if (RCL_RET_OK != ret) {
8084
rclcpp::exceptions::throw_from_rcl_error(ret);

rclcpp/src/rclcpp/service.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,10 @@ ServiceBase::take_type_erased_request(void * request_out, rmw_request_id_t & req
4242
&request_id_out,
4343
request_out);
4444
if (RCL_RET_SERVICE_TAKE_FAILED == ret) {
45+
RCLCPP_ERROR(
46+
rclcpp::get_logger("rclcpp"),
47+
"Error in take_type_erased_request: RCL_RET_SERVICE_TAKE_FAILED. "
48+
"Service name: %s", get_service_name());
4549
return false;
4650
} else if (RCL_RET_OK != ret) {
4751
rclcpp::exceptions::throw_from_rcl_error(ret);

0 commit comments

Comments
 (0)