Fix memory leak #13036 (#13045)

* try to fix memory leak

* extract `memoize` function

* changeset

* byte shaving

* Clean up Prettier, Size-limit, and Api-Extractor

---------

Co-authored-by: phryneas <[email protected]>

Author: phryneas

.changeset/long-cats-check.md

@@ -0,0 +1,5 @@
+---
+"@apollo/client": patch
+---
+
+Fix memory leak #13036

.size-limits.json

@@ -1,6 +1,6 @@
 {
-  "import { ApolloClient, InMemoryCache, HttpLink } from \"@apollo/client\" (CJS)": 43931,
-  "import { ApolloClient, InMemoryCache, HttpLink } from \"@apollo/client\" (production) (CJS)": 38761,
-  "import { ApolloClient, InMemoryCache, HttpLink } from \"@apollo/client\"": 33451,
-  "import { ApolloClient, InMemoryCache, HttpLink } from \"@apollo/client\" (production)": 27513
+  "import { ApolloClient, InMemoryCache, HttpLink } from \"@apollo/client\" (CJS)": 44009,
+  "import { ApolloClient, InMemoryCache, HttpLink } from \"@apollo/client\" (production) (CJS)": 38803,
+  "import { ApolloClient, InMemoryCache, HttpLink } from \"@apollo/client\"": 33512,
+  "import { ApolloClient, InMemoryCache, HttpLink } from \"@apollo/client\" (production)": 27576
 }

src/utilities/internal/checkDocument.ts

@@ -1,10 +1,8 @@
 // Checks the document for errors and throws an exception if there is an error.
 
-import { WeakCache } from "@wry/caches";
 import type { ASTNode } from "graphql";
 import type { DocumentNode, OperationTypeNode } from "graphql";
 import { Kind, visit } from "graphql";
-import { wrap } from "optimism";
 
 import { __DEV__ } from "@apollo/client/utilities/environment";
 import {
@@ -16,6 +14,7 @@ import { defaultCacheSizes } from "../../utilities/caching/sizes.js";
 import { cacheSizes } from "../caching/sizes.js";
 
 import { getOperationName } from "./getOperationName.js";
+import { memoize } from "./memoize.js";
 
 /**
  * Checks the document for errors and throws an exception if there is an error.
@@ -25,7 +24,7 @@ import { getOperationName } from "./getOperationName.js";
 export const checkDocument: (
   doc: DocumentNode,
   expectedType?: OperationTypeNode
-) => void = wrap(
+) => void = memoize(
   (doc: DocumentNode, expectedType?: OperationTypeNode): void => {
     invariant(
       doc && doc.kind === "Document",
@@ -97,6 +96,5 @@ string in a "gql" tag? http://docs.apollostack.com/apollo-client/core.html#gql`
   },
   {
     max: cacheSizes["checkDocument"] || defaultCacheSizes["checkDocument"],
-    cache: WeakCache,
   }
 );

src/utilities/internal/memoize.ts

@@ -0,0 +1,36 @@
+import { Trie } from "@wry/trie";
+
+import { AutoCleanedWeakCache } from "./caches.js";
+
+/**
+ * Naive alternative to `wrap` without any dependency tracking, potentially avoiding resulting memory leaks.
+ */
+export function memoize<TArgs extends any[], TResult>(
+  fn: (...args: TArgs) => TResult,
+  { max }: { max: number }
+): (...args: TArgs) => TResult {
+  const keys = new Trie<{}>(true);
+  const cache = new AutoCleanedWeakCache<
+    {},
+    { result?: TResult; error?: unknown }
+  >(max);
+
+  return (...args: TArgs): TResult => {
+    const cacheKey = keys.lookupArray(args);
+    const cached = cache.get(cacheKey);
+    if (cached) {
+      if (cached.error) {
+        throw cached.error;
+      }
+      return cached.result!;
+    }
+
+    const entry = cache.set(cacheKey, {});
+    try {
+      return (entry.result = fn(...args));
+    } catch (error) {
+      entry.error = error;
+      throw error;
+    }
+  };
+}