useSuspenseQuery(..., skipToken) should always return undefined data type

[nekocode]

Issue Description

useSuspenseQuery(..., skipToken) should always return undefined data type. Currently returns DeepPartial<TData> | undefined type:

Link to Reproduction

none

Reproduction Steps

No response

@apollo/client version

3.11.8

[samchungy]

Is there really a use-case for this though?

I feel like you'd always use a ternary in there anyway? I don't understand what the purpose of only putting skipToken in there would be?

[nekocode]

@samchungy When writing a wrapper function for useSuspenseQuery, it may be needed. For example, dotansimha/graphql-code-generator-community#878 Currently I need to forcibly convert the parameter to SkipToken | undefined type in order to make the return data type not DeepPartial.

[nekocode]

I'm sorry I forgot an important point, hook cannot be conditionally called (even though it can work). Under these restrictions, it is indeed impossible to only pass the skipToken, unless by accident (For example in some preceding wrong logic, the parameter is only calculated as type skipToken)

I'm not sure if you still need this change. If not, please close this issue/PR.

[phryneas]

Hi @nekocode,
sorry for the slow response - we're all just back from conferences :)

I agree that the change "feels" like something that would be nice, bus as @samchungy and you already noticed - it doesn't really apply unless someone would hard-code skipToken, in which code they also could comment out the code.

As suggested, I'm gonna close the PR - this case is so rare that we should probably opt for one less method overload. We already have too many of those 😅

Thank you for the PR though!

[github-actions]

Do you have any feedback for the maintainers? Please tell us by taking a one-minute survey. Your responses will help us understand Apollo Client usage and allow us to serve you better.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
For general questions, we recommend using StackOverflow or our discord server.