`renderToStringWithData`/`getDataFromTree` unbatched

[dkempner]

Why?

These functions work well and minimize the number of renders that happen during Server Side Rendering, but they also potentially block progress and contribute to longer SSR times if there's a non-blocking query in a batch.

What?

This issue is more of a discussion than a request. I'm wondering why we don't have the option for consumeAndAwaitPromises to work more like a promise.any instead of promise.all. We could debounce it a bit so not every single promise returned will kick off the next render.

Would this be something we could add as an option to renderToStringWithData?

[phryneas]

On the flip side, this will cause a lot more work for your server.

We do make a bunch of changes to the SSR methods in 4.0, but in the long run, the correct solution here would probably be to use the suspenseful hooks (which will be possible with SSR in 4.0) as those will immediately start granular rendering again, which means it will do what you request here and have fewer full render passes in total on top.

Apollo Client 4.0 is currently in RC, so any feedback how those new APIs work for you is very welcome :)

[dkempner]

Thanks @phryneas . So far I'm not in love with the suspenseful hooks. In a way they kind of remind me of async functions because they don't play well with non-suspenseful useQuerys.

Do you have a link to docs on how to do SSR in 4.0?

I do agree that my proposal would cause more work on the server, but I'm willing to shoulder that if it means the page loads faster :).

[phryneas]

In a way they kind of remind me of async functions because they don't play well with non-suspenseful useQuerys.

Yeah, it's usually an either-or, you probably wouldn't combine those too much - but as a benefit you only have to handle very few loading states in the end.

Do you have a link to docs on how to do SSR in 4.0?

We're not done documenting them yet, but here's the most relevant changeset (with more changesets in that PR):

• #12488 c98b633 Thanks @phryneas! - Add a new method for static SSR of React components, prerenderStatic.
  The old methods, getDataFromTree, getMarkupFromTree and renderToStringWithData
  have been deprecated in favor of prerenderStatic.

  If used with React 19 and the prerender or prerenderToNodeStream apis from
  react-dom/static, this method can now be used to SSR-prerender suspense-enabled
  hook APIs.

[dkempner]

Thanks for the links!!

---

---

It'll be quite a migration to adopt everywhere for my team. Obviously that takes nothing away from what you're doing, but it makes the recommendation to adopt suspenseful hooks a long-term one!

[dkempner]

I've started a WIP PR in case you're interested.

[phryneas]

Commenting over there then :)