Skip to content

Ensure that PreloadedQueryRef instances are unsubscribed when garbage collected #12884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Ensure that PreloadedQueryRef instances are unsubscribed when garbage collected #12884

wants to merge 4 commits into from

Conversation

@phryneas
Copy link
Member

@phryneas phryneas requested a review from jerelmiller August 28, 2025 12:31
@changeset-bot
Copy link

changeset-bot bot commented Aug 28, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 54bf355

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Aug 28, 2025 •
edited
Loading 

npm i https://pkg.pr.new/apollographql/apollo-client/@apollo/client@12884

commit: 54bf355

@github-actions
Copy link
Contributor

github-actions bot commented Aug 28, 2025 •
edited
Loading

size-limit report 📦

Path Size
import { ApolloClient, InMemoryCache, HttpLink } from "@apollo/client" (CJS) 42.84 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "@apollo/client" (production) (CJS) 37.84 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "@apollo/client" 32.81 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "@apollo/client" (production) 27 KB (0%)
import { ApolloProvider } from "@apollo/client/react" 5.9 KB (0%)
import { ApolloProvider } from "@apollo/client/react" (production) 968 B (0%)
import { useQuery } from "@apollo/client/react" 7.21 KB (0%)
import { useQuery } from "@apollo/client/react" (production) 2.22 KB (0%)
import { useLazyQuery } from "@apollo/client/react" 7.09 KB (0%)
import { useLazyQuery } from "@apollo/client/react" (production) 2.13 KB (0%)
import { useMutation } from "@apollo/client/react" 6.45 KB (0%)
import { useMutation } from "@apollo/client/react" (production) 1.47 KB (0%)
import { useSubscription } from "@apollo/client/react" 6.78 KB (0%)
import { useSubscription } from "@apollo/client/react" (production) 1.79 KB (0%)
import { useSuspenseQuery } from "@apollo/client/react" 8.57 KB (0%)
import { useSuspenseQuery } from "@apollo/client/react" (production) 3.62 KB (0%)
import { useBackgroundQuery } from "@apollo/client/react" 8.31 KB (0%)
import { useBackgroundQuery } from "@apollo/client/react" (production) 3.38 KB (0%)
import { useLoadableQuery } from "@apollo/client/react" 8.3 KB (0%)
import { useLoadableQuery } from "@apollo/client/react" (production) 3.35 KB (0%)
import { useReadQuery } from "@apollo/client/react" 6.59 KB (0%)
import { useReadQuery } from "@apollo/client/react" (production) 1.62 KB (0%)
import { useFragment } from "@apollo/client/react" 6.65 KB (0%)
import { useFragment } from "@apollo/client/react" (production) 1.68 KB (0%)

@apollo-librarian
Copy link

apollo-librarian bot commented Aug 28, 2025 •
edited
Loading

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: 1408162f1eb8a6632fdbfc3d
Build Logs: View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jerelmiller jerelmiller Awaiting requested review from jerelmiller

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@phryneas