Skip to content

Commit 3249054

Browse files
authored
Re-enable verifier's compatibility problems (#24)
* Re-enable verifier's compatibility problems * Use macos-latest for the verify job. * Get rid of free-disk-space step
1 parent aeeec97 commit 3249054

File tree

2 files changed

+7
-19
lines changed

2 files changed

+7
-19
lines changed

.github/workflows/build-and-verify.yml

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -109,22 +109,11 @@ jobs:
109109
verify:
110110
name: Verify plugin
111111
needs: [ build ]
112-
runs-on: ubuntu-latest
112+
# Use macOS for Plugin Verifier, due to https://youtrack.jetbrains.com/issue/MP-7480
113+
runs-on: macos-latest
113114
timeout-minutes: 120
114115
steps:
115116

116-
# Free GitHub Actions Environment Disk Space
117-
- name: Maximize Build Space
118-
uses: jlumbroso/free-disk-space@54081f138730dfa15788a46383842cd2f914a1be #v1.3.1
119-
with:
120-
tool-cache: false
121-
android: false
122-
dotnet: true
123-
haskell: true
124-
large-packages: true
125-
docker-images: true
126-
swap-storage: true
127-
128117
# Check out the current repository
129118
- name: Fetch Sources
130119
uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 #v4.1.7

plugin/build.gradle.kts

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@ import org.gradle.api.tasks.testing.logging.TestExceptionFormat
22
import org.gradle.api.tasks.testing.logging.TestLogEvent
33
import org.jetbrains.changelog.markdownToHTML
44
import org.jetbrains.intellij.platform.gradle.TestFrameworkType
5+
import org.jetbrains.intellij.platform.gradle.tasks.VerifyPluginTask
6+
import org.jetbrains.intellij.platform.gradle.tasks.VerifyPluginTask.FailureLevel.COMPATIBILITY_PROBLEMS
57
import org.jetbrains.intellij.platform.gradle.tasks.VerifyPluginTask.FailureLevel.INTERNAL_API_USAGES
68
import org.jetbrains.intellij.platform.gradle.tasks.VerifyPluginTask.FailureLevel.INVALID_PLUGIN
79
import org.jetbrains.intellij.platform.gradle.tasks.VerifyPluginTask.FailureLevel.PLUGIN_STRUCTURE_WARNINGS
@@ -153,9 +155,8 @@ dependencies {
153155
create(type = properties("platformType"), version = properties("platformVersion"))
154156
bundledPlugins(properties("platformBundledPlugins").split(',').map(String::trim).filter(String::isNotEmpty))
155157
plugins(properties("platformPlugins").split(',').map(String::trim).filter(String::isNotEmpty))
156-
// Use a specific version of the verifier
157-
// TODO: remove when https://youtrack.jetbrains.com/issue/MP-7366 is fixed
158-
pluginVerifier(version = "1.383")
158+
// Uncomment the version if needing a specific one, e.g. if a regression is introduced in the latest version - see https://github.com/JetBrains/intellij-plugin-verifier/releases
159+
pluginVerifier(/*version = "1.385"*/)
159160
testFramework(TestFrameworkType.Plugin.Java)
160161
zipSigner()
161162
}
@@ -238,9 +239,7 @@ intellijPlatform {
238239
}
239240
failureLevel.set(
240241
setOf(
241-
// Temporarily disabled due to https://platform.jetbrains.com/t/plugin-verifier-fails-with-plugin-com-intellij-modules-json-not-declared-as-a-plugin-dependency/580
242-
// TODO: Uncomment when https://youtrack.jetbrains.com/issue/MP-7366 is fixed
243-
// COMPATIBILITY_PROBLEMS,
242+
COMPATIBILITY_PROBLEMS,
244243
INTERNAL_API_USAGES,
245244
INVALID_PLUGIN,
246245
PLUGIN_STRUCTURE_WARNINGS,

0 commit comments

Comments
 (0)