Squashed 'apollo-ios-codegen/' changes from ec18790f..4b1bc5bc

4b1bc5bc feature: Identifiable conformance for Named Fragments (#595)

git-subtree-dir: apollo-ios-codegen
git-subtree-split: 4b1bc5bcdecab067326e4ba77e651f662d1a1d19

Author: gh-action-runner

Sources/ApolloCodegenLib/Templates/FragmentTemplate.swift

@@ -23,7 +23,9 @@ struct FragmentTemplate: TemplateRenderer {
     """
     \(accessControlModifier(for: .parent))\
     struct \(fragment.generatedDefinitionName.asFragmentName): \
-    \(fragment.renderedSelectionSetType(config)), Fragment {
+    \(fragment.renderedSelectionSetType(config)), Fragment\
+    \(if: fragment.isIdentifiable, ", Identifiable")\
+     {
     \(if: includeDefinition, """
       \(accessControlModifier(for: .member))\
     static var fragmentDefinition: StaticString {

Sources/IR/GraphQLCompositeType+Identifiable.swift

@@ -0,0 +1,17 @@
+import GraphQLCompiler
+
+extension GraphQLCompositeType {
+  /// Indicates if the type has a single keyField named `id`.
+  var isIdentifiable: Bool {
+    switch(self) {
+    case let interface as GraphQLInterfaceType:
+      return interface.keyFields == ["id"]
+
+    case let object as GraphQLObjectType:
+      return object.keyFields == ["id"]
+
+    default:
+      return false
+    }
+  }
+}

Sources/IR/IR+ComputedSelectionSet.swift

@@ -20,22 +20,14 @@ public struct ComputedSelectionSet {
   /// The `TypeInfo` for the selection set of the computed selections
   public let typeInfo: IR.SelectionSet.TypeInfo
 
-  /// Indicates if the parent type has a single keyField named `id`.
+  /// Indicates if a field named `id` is selected as well as requiring that the parent type
+  /// be identifiable.
   public var isIdentifiable: Bool {
     guard direct?.fields["id"] != nil || merged.fields["id"] != nil else {
       return false
     }
-    if let type = typeInfo.parentType as? GraphQLObjectType,
-       type.keyFields == ["id"] {
-      return true
-    }
-    
-    if let type = typeInfo.parentType as? GraphQLInterfaceType,
-       type.keyFields == ["id"] {
-      return true
-    }
-    
-    return false
+
+    return typeInfo.parentType.isIdentifiable
   }
 
   // MARK: Dynamic Member Subscript

Sources/IR/IR+NamedFragment.swift

@@ -22,6 +22,17 @@ public class NamedFragment: Definition, Hashable, CustomDebugStringConvertible {
   public var name: String { definition.name }
   public var type: GraphQLCompositeType { definition.type }
   public var isLocalCacheMutation: Bool { definition.isLocalCacheMutation }
+  
+  /// Indicates if a field named `id` is selected as well as requiring that the parent type
+  /// be identifiable.
+  public var isIdentifiable: Bool {
+    guard definition.selectionSet.selections.contains(where: {
+      guard case .field(let field) = $0 else { return false }
+      return field.name == "id"
+    }) else { return false }
+    
+    return type.isIdentifiable
+  }
 
   init(
     definition: CompilationResult.FragmentDefinition,