Skip to content

Conversation

bignimbus
Copy link
Contributor

@bignimbus bignimbus commented Jun 6, 2025

TODO

Before marking as ready for review:

  • Update other READMEs
  • Verify links

Copy link

netlify bot commented Jun 6, 2025

Deploy Preview for apollo-ios-docc canceled.

Name Link
🔨 Latest commit 9ac078c
🔍 Latest deploy log https://app.netlify.com/projects/apollo-ios-docc/deploys/6866aed3b8da1100082c23aa

Copy link
Member

@calvincestari calvincestari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, looks good otherwise - thank you!

@apollo-librarian
Copy link

apollo-librarian bot commented Jul 3, 2025

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: 20efcdbf3e0ab11c34291792

@bignimbus bignimbus marked this pull request as ready for review July 3, 2025 16:25
Copy link
Member

@calvincestari calvincestari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you.

At some time we should change the build status badge too. I think that might be more relevant to apollo-ios-dev though with the nightly build.

@bignimbus bignimbus merged commit c681e58 into main Aug 28, 2025
32 checks passed
@bignimbus bignimbus deleted the jeff/readme branch August 28, 2025 15:53
BobaFetters pushed a commit to apollographql/apollo-ios that referenced this pull request Aug 28, 2025
BobaFetters pushed a commit that referenced this pull request Aug 28, 2025
e47ba686b New README info architecture and content (#665)
095f6062b More code review updates
3815b9b94 Apply suggestions from code review
8682e9305 Update README.md
b028c0fea New README info architecture and content

git-subtree-dir: apollo-ios
git-subtree-split: e47ba686b3d90de632148e77652745506665da1f
BobaFetters pushed a commit that referenced this pull request Aug 28, 2025
git-subtree-dir: apollo-ios
git-subtree-mainline: bce295b
git-subtree-split: e47ba686b3d90de632148e77652745506665da1f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants