-
Notifications
You must be signed in to change notification settings - Fork 69
New README info architecture and content #665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for apollo-ios-docc canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments, looks good otherwise - thank you!
Co-authored-by: Calvin Cestari <[email protected]>
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: 20efcdbf3e0ab11c34291792 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you.
At some time we should change the build status badge too. I think that might be more relevant to apollo-ios-dev though with the nightly build.
e47ba686b New README info architecture and content (#665) 095f6062b More code review updates 3815b9b94 Apply suggestions from code review 8682e9305 Update README.md b028c0fea New README info architecture and content git-subtree-dir: apollo-ios git-subtree-split: e47ba686b3d90de632148e77652745506665da1f
git-subtree-dir: apollo-ios git-subtree-mainline: bce295b git-subtree-split: e47ba686b3d90de632148e77652745506665da1f
TODO
Before marking as ready for review: