Disable logs in tests (#5979)

martinbonnin · web-flow · commit 14ac1e8de846 · 2024-06-18T11:43:55.000+02:00
diff --git a/gradle/libraries.toml b/gradle/libraries.toml
@@ -199,7 +199,8 @@ truth = { group = "com.google.truth", name = "truth", version.ref = "truth" }
 turbine = { group = "app.cash.turbine", name = "turbine", version = "1.1.0" }
 uuid = { group = "com.benasher44", name = "uuid", version = "0.8.2" }
 vespene = { group = "net.mbonnin.vespene", name = "vespene-lib", version = "0.5" }
-slf4j = "org.slf4j:slf4j-simple:2.0.9"
+slf4j-simple = "org.slf4j:slf4j-simple:2.0.13"
+slf4j-nop = "org.slf4j:slf4j-nop:2.0.13"
 
 [plugins]
 apollo = { id = "com.apollographql.apollo3", version.ref = "apollo" }
diff --git a/intellij-plugin/build.gradle.kts b/intellij-plugin/build.gradle.kts
@@ -177,7 +177,7 @@ dependencies {
   implementation(project(":apollo-normalized-cache-sqlite"))
   implementation(libs.sqlite.jdbc)
   implementation(libs.apollo.runtime.published)
-  runtimeOnly(libs.slf4j)
+  runtimeOnly(libs.slf4j.simple)
   testImplementation(libs.google.testparameterinjector)
 }
 
diff --git a/libraries/apollo-debug-server/build.gradle.kts b/libraries/apollo-debug-server/build.gradle.kts
@@ -40,7 +40,7 @@ kotlin {
       dependencies {
         implementation(libs.apollo.execution.ktor)
         implementation(libs.ktor.server.cio)
-        implementation(libs.slf4j)
+        implementation(libs.slf4j.nop)
       }
     }
     getByName("jvmTest") {
diff --git a/libraries/apollo-gradle-plugin/build.gradle.kts b/libraries/apollo-gradle-plugin/build.gradle.kts
@@ -41,7 +41,7 @@ dependencies {
   testImplementation(platform(libs.http4k.bom.get()))
   testImplementation(libs.http4k.core)
   testImplementation(libs.http4k.server.jetty)
-  testImplementation(libs.slf4j.get().toString()) {
+  testImplementation(libs.slf4j.nop.get().toString()) {
     because("jetty uses SL4F")
   }
 
diff --git a/libraries/apollo-normalized-cache-sqlite-incubating/build.gradle.kts b/libraries/apollo-normalized-cache-sqlite-incubating/build.gradle.kts
@@ -60,7 +60,7 @@ kotlin {
     findByName("jvmTest")?.apply {
       dependencies {
         implementation(libs.truth)
-        implementation(libs.slf4j)
+        implementation(libs.slf4j.nop)
       }
     }
 
diff --git a/libraries/apollo-normalized-cache-sqlite/build.gradle.kts b/libraries/apollo-normalized-cache-sqlite/build.gradle.kts
@@ -46,7 +46,7 @@ kotlin {
     findByName("jvmTest")?.apply {
       dependencies {
         implementation(libs.truth)
-        implementation(libs.slf4j)
+        implementation(libs.slf4j.nop)
       }
     }
 
diff --git a/tests/engine/build.gradle.kts b/tests/engine/build.gradle.kts
@@ -29,7 +29,7 @@ kotlin {
       dependsOn(commonTest)
       dependencies {
         implementation(libs.apollo.engine.ktor)
-        implementation(libs.slf4j)
+        implementation(libs.slf4j.nop)
       }
     }
     val defaultTest = create("defaultTest") {
diff --git a/tests/pagination/build.gradle.kts b/tests/pagination/build.gradle.kts
@@ -29,7 +29,7 @@ kotlin {
 
     findByName("jvmTest")?.apply {
       dependencies {
-        implementation(libs.slf4j)
+        implementation(libs.slf4j.nop)
       }
     }
   }
diff --git a/tests/sample-server/build.gradle.kts b/tests/sample-server/build.gradle.kts
@@ -26,7 +26,7 @@ dependencies {
   implementation(platform(libs.http4k.bom.get()))
   implementation(libs.http4k.core)
   implementation(libs.http4k.server.jetty)
-  implementation(libs.slf4j.get().toString()) {
+  implementation(libs.slf4j.nop.get().toString()) {
     because("jetty uses SL4F")
   }
 }
diff --git a/tests/sqlite/build.gradle.kts b/tests/sqlite/build.gradle.kts
@@ -25,7 +25,7 @@ kotlin {
     }
     findByName("jvmTest")?.apply {
       dependencies {
-        implementation(libs.slf4j)
+        implementation(libs.slf4j.nop)
       }
 
     }

Original file line number	Diff line number	Diff line change
`@@ -177,7 +177,7 @@ dependencies {`
`177`	`177`	`implementation(project(":apollo-normalized-cache-sqlite"))`
`178`	`178`	`implementation(libs.sqlite.jdbc)`
`179`	`179`	`implementation(libs.apollo.runtime.published)`
`180`		`- runtimeOnly(libs.slf4j)`
	`180`	`+ runtimeOnly(libs.slf4j.simple)`
`181`	`181`	`testImplementation(libs.google.testparameterinjector)`
`182`	`182`	`}`
`183`	`183`
Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ kotlin {`
`40`	`40`	`dependencies {`
`41`	`41`	`implementation(libs.apollo.execution.ktor)`
`42`	`42`	`implementation(libs.ktor.server.cio)`
`43`		`- implementation(libs.slf4j)`
	`43`	`+ implementation(libs.slf4j.nop)`
`44`	`44`	`}`
`45`	`45`	`}`
`46`	`46`	`getByName("jvmTest") {`
Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ dependencies {`
`41`	`41`	`testImplementation(platform(libs.http4k.bom.get()))`
`42`	`42`	`testImplementation(libs.http4k.core)`
`43`	`43`	`testImplementation(libs.http4k.server.jetty)`
`44`		`- testImplementation(libs.slf4j.get().toString()) {`
	`44`	`+ testImplementation(libs.slf4j.nop.get().toString()) {`
`45`	`45`	`because("jetty uses SL4F")`
`46`	`46`	`}`
`47`	`47`
Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ kotlin {`
`60`	`60`	`findByName("jvmTest")?.apply {`
`61`	`61`	`dependencies {`
`62`	`62`	`implementation(libs.truth)`
`63`		`- implementation(libs.slf4j)`
	`63`	`+ implementation(libs.slf4j.nop)`
`64`	`64`	`}`
`65`	`65`	`}`
`66`	`66`
Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ kotlin {`
`46`	`46`	`findByName("jvmTest")?.apply {`
`47`	`47`	`dependencies {`
`48`	`48`	`implementation(libs.truth)`
`49`		`- implementation(libs.slf4j)`
	`49`	`+ implementation(libs.slf4j.nop)`
`50`	`50`	`}`
`51`	`51`	`}`
`52`	`52`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ kotlin {`
`29`	`29`	`dependsOn(commonTest)`
`30`	`30`	`dependencies {`
`31`	`31`	`implementation(libs.apollo.engine.ktor)`
`32`		`- implementation(libs.slf4j)`
	`32`	`+ implementation(libs.slf4j.nop)`
`33`	`33`	`}`
`34`	`34`	`}`
`35`	`35`	`val defaultTest = create("defaultTest") {`
Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ dependencies {`
`26`	`26`	`implementation(platform(libs.http4k.bom.get()))`
`27`	`27`	`implementation(libs.http4k.core)`
`28`	`28`	`implementation(libs.http4k.server.jetty)`
`29`		`- implementation(libs.slf4j.get().toString()) {`
	`29`	`+ implementation(libs.slf4j.nop.get().toString()) {`
`30`	`30`	`because("jetty uses SL4F")`
`31`	`31`	`}`
`32`	`32`	`}`
Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ kotlin {`
`25`	`25`	`}`
`26`	`26`	`findByName("jvmTest")?.apply {`
`27`	`27`	`dependencies {`
`28`		`- implementation(libs.slf4j)`
	`28`	`+ implementation(libs.slf4j.nop)`
`29`	`29`	`}`
`30`	`30`
`31`	`31`	`}`