validate query/mutation/subscription directives (#5113)

Author: martinbonnin

libraries/apollo-ast/src/commonMain/kotlin/com/apollographql/apollo3/ast/internal/ExecutableValidationScope.kt

@@ -35,8 +35,8 @@ import com.apollographql.apollo3.ast.SourceLocation
 import com.apollographql.apollo3.ast.VariableUsage
 import com.apollographql.apollo3.ast.definitionFromScope
 import com.apollographql.apollo3.ast.findDeprecationReason
-import com.apollographql.apollo3.ast.rawType
 import com.apollographql.apollo3.ast.pretty
+import com.apollographql.apollo3.ast.rawType
 import com.apollographql.apollo3.ast.responseName
 import com.apollographql.apollo3.ast.rootTypeDefinition
 import com.apollographql.apollo3.ast.sharesPossibleTypesWith
@@ -336,6 +336,11 @@ internal class ExecutableValidationScope(
 
     fieldsInSetCanMerge(selections.collectFields(rootTypeDefinition.name))
 
+    directives.forEach {
+      validateDirective(it, this) {
+        variableUsages.add(it)
+      }
+    }
     variableUsages.forEach {
       validateVariable(this, it)
     }

libraries/apollo-ast/src/commonMain/kotlin/com/apollographql/apollo3/ast/internal/ValidationCommon.kt

@@ -19,7 +19,6 @@ import com.apollographql.apollo3.ast.GQLNonNullType
 import com.apollographql.apollo3.ast.GQLNullValue
 import com.apollographql.apollo3.ast.GQLObjectTypeDefinition
 import com.apollographql.apollo3.ast.GQLOperationDefinition
-import com.apollographql.apollo3.ast.GQLOperationTypeDefinition
 import com.apollographql.apollo3.ast.GQLScalarTypeDefinition
 import com.apollographql.apollo3.ast.GQLSchemaDefinition
 import com.apollographql.apollo3.ast.GQLSchemaExtension
@@ -104,7 +103,7 @@ internal fun ValidationScope.validateDirective(
     is GQLInlineFragment -> GQLDirectiveLocation.INLINE_FRAGMENT
     is GQLFragmentSpread -> GQLDirectiveLocation.FRAGMENT_SPREAD
     is GQLObjectTypeDefinition -> GQLDirectiveLocation.OBJECT
-    is GQLOperationTypeDefinition -> {
+    is GQLOperationDefinition -> {
       when (directiveContext.operationType) {
         "query" -> GQLDirectiveLocation.QUERY
         "mutation" -> GQLDirectiveLocation.MUTATION

libraries/apollo-compiler/src/test/validation/operation/directive_variable/directive_variable.expected

@@ -0,0 +1,4 @@
+# See https://github.com/apollographql/apollo-kotlin/issues/5112
+query Collection($country: String) @inContext(country: $country) {
+    random
+}

libraries/apollo-compiler/src/test/validation/operation/directive_variable/directive_variable.graphql

@@ -0,0 +1,5 @@
+type Query {
+    random: String
+}
+
+directive @inContext(country: String) on QUERY