check is always failing, might as well make it an error (#5153)

Author: martinbonnin

libraries/apollo-ast/src/commonMain/kotlin/com/apollographql/apollo3/ast/gqltype.kt

@@ -92,14 +92,11 @@ private fun GQLType.withItemNullability(itemNullability: GQLNullability?, valida
   if (this !is GQLListType) {
     when (validation) {
       is NullabilityValidationThrow -> {
-        check(this is GQLListType) {
-          "Cannot apply nullability, the nullability list dimension exceeds the one of the field type."
-        }
+        error("Cannot apply nullability, the nullability list dimension exceeds the one of the field type.")
       }
 
       is NullabilityValidationIgnore -> {
         return this
-
       }
 
       is NullabilityValidationRegister -> {

libraries/apollo-ast/src/commonTest/kotlin/com/apollographql/apollo3/graphql/ast/test/GQLTest.kt renamed to libraries/apollo-ast/src/commonTest/kotlin/com/apollographql/apollo3/graphql/ast/test/CcnTest.kt

@@ -9,7 +9,7 @@ import com.apollographql.apollo3.ast.withNullability
 import kotlin.test.Test
 import kotlin.test.assertEquals
 
-class GQLTest {
+class CcnTest {
   @Test
   fun type() {
     val newType = "[String!]!".parseAsGQLType().getOrThrow().withNullability(GQLListNullability(selfNullability = null, itemNullability = GQLNullDesignator()))