Nullability: remove @ignoreErrors, @catchField and add @catchByDefault (#6002)

* Bump to nullability v0.4

* add test for `@catch(to: NULL)`

* remove @ignoreErrors

* fix IJ plugin tests

Author: martinbonnin

intellij-plugin/src/main/resources/inspectionDescriptions/ApolloMissingGraphQLDefinitionImport.html

@@ -4,12 +4,12 @@
 <p>
     Before being referenced, directives and types supported by Apollo Kotlin must be imported by your schema using the <code>@link</code> directive<br>.
     For instance, to use the <code>@semanticNonNull</code> directive, import it from the
-    <a href="https://specs.apollo.dev/nullability/v0.3"><code>nullability</code></a> definitions:
+    <a href="https://specs.apollo.dev/nullability/v0.4"><code>nullability</code></a> definitions:
 <pre>
         extend schema
         @link(
-          url: "https://specs.apollo.dev/nullability/v0.3",
-          import: ["@semanticNonNull"]
+          url: "https://specs.apollo.dev/nullability/v0.4",
+          import: ["@semanticNonNull", "@catch", "@CatchTo", "@catchByDefault"]
         )
     </pre>
 </p>

intellij-plugin/src/test/testData/inspection/MissingGraphQLDefinitionImport/missing-CatchTo-extra.graphqls

@@ -1,5 +1,5 @@
 extend schema
 @link(
-  url: "https://specs.apollo.dev/nullability/v0.3",
+  url: "https://specs.apollo.dev/nullability/v0.4",
   import: ["@catch"]
-)
+)

intellij-plugin/src/test/testData/inspection/MissingGraphQLDefinitionImport/missing-CatchTo-extra_after.graphqls

@@ -1,5 +1,5 @@
 extend schema
 @link(
-  url: "https://specs.apollo.dev/nullability/v0.3",
+  url: "https://specs.apollo.dev/nullability/v0.4",
   import: ["@catch", "CatchTo"]
-)
+)

intellij-plugin/src/test/testData/inspection/MissingGraphQLDefinitionImport/missing-catch-extra_after.graphqls

@@ -1,5 +1,5 @@
 extend schema
 @link(
-  url: "https://specs.apollo.dev/nullability/v0.3",
+  url: "https://specs.apollo.dev/nullability/v0.4",
   import: ["@catch", "CatchTo"]
 )

intellij-plugin/src/test/testData/inspection/MissingGraphQLDefinitionImport/missing-targetName-extra.graphqls

@@ -1,7 +1,7 @@
 extend schema
 @link(
-  url: "https://specs.apollo.dev/nullability/v0.3",
-  import: ["@catch", "CatchTo"]
+  url: "https://specs.apollo.dev/nullability/v0.4",
+  import: ["@catch", "@catchByDefault", "CatchTo"]
 )
 
-extend schema @catch(to: THROW)
+extend schema @catchByDefault(to: THROW)

intellij-plugin/src/test/testData/inspection/MissingGraphQLDefinitionImport/missing-targetName-extra_after.graphqls

@@ -6,8 +6,8 @@ extend schema
 
 extend schema
 @link(
-  url: "https://specs.apollo.dev/nullability/v0.3",
-  import: ["@catch", "CatchTo"]
+  url: "https://specs.apollo.dev/nullability/v0.4",
+  import: ["@catch", "@catchByDefault", "CatchTo"]
 )
 
-extend schema @catch(to: THROW)
+extend schema @catchByDefault(to: THROW)

libraries/apollo-api/api/apollo-api.api

@@ -521,7 +521,6 @@ public final class com/apollographql/apollo3/api/Error$Location {
 
 public abstract interface class com/apollographql/apollo3/api/Executable {
 	public abstract fun adapter ()Lcom/apollographql/apollo3/api/Adapter;
-	public abstract fun getIgnoreErrors ()Z
 	public abstract fun rootField ()Lcom/apollographql/apollo3/api/CompiledField;
 	public abstract fun serializeVariables (Lcom/apollographql/apollo3/api/json/JsonWriter;Lcom/apollographql/apollo3/api/CustomScalarAdapters;Z)V
 }

libraries/apollo-api/api/apollo-api.klib.api

@@ -42,8 +42,6 @@ abstract interface <#A: com.apollographql.apollo3.api/Executable.Data> com.apoll
     abstract fun rootField(): com.apollographql.apollo3.api/CompiledField // com.apollographql.apollo3.api/Executable.rootField|rootField(){}[0]
     abstract fun serializeVariables(com.apollographql.apollo3.api.json/JsonWriter, com.apollographql.apollo3.api/CustomScalarAdapters, kotlin/Boolean) // com.apollographql.apollo3.api/Executable.serializeVariables|serializeVariables(com.apollographql.apollo3.api.json.JsonWriter;com.apollographql.apollo3.api.CustomScalarAdapters;kotlin.Boolean){}[0]
     abstract interface Data // com.apollographql.apollo3.api/Executable.Data|null[0]
-    abstract val ignoreErrors // com.apollographql.apollo3.api/Executable.ignoreErrors|{}ignoreErrors[0]
-        abstract fun <get-ignoreErrors>(): kotlin/Boolean // com.apollographql.apollo3.api/Executable.ignoreErrors.<get-ignoreErrors>|<get-ignoreErrors>(){}[0]
     final class Variables { // com.apollographql.apollo3.api/Executable.Variables|null[0]
         constructor <init>(kotlin.collections/Map<kotlin/String, kotlin/Any?>) // com.apollographql.apollo3.api/Executable.Variables.<init>|<init>(kotlin.collections.Map<kotlin.String,kotlin.Any?>){}[0]
         final val valueMap // com.apollographql.apollo3.api/Executable.Variables.valueMap|{}valueMap[0]

libraries/apollo-api/src/commonMain/kotlin/com/apollographql/apollo3/api/Executable.kt

@@ -30,12 +30,6 @@ interface Executable<D: Executable.Data> {
    */
   fun rootField(): CompiledField
 
-  /**
-   * A flag to disable error checking for the whole operation.
-   * Used for backward compatibility.
-   */
-  val ignoreErrors: Boolean
-
   /**
    * Marker interface for generated models
    */

libraries/apollo-api/src/commonMain/kotlin/com/apollographql/apollo3/api/Executables.kt

@@ -77,7 +77,7 @@ fun <D : Executable.Data> Executable<D>.parseData(
   val customScalarAdapters1 = customScalarAdapters.newBuilder()
       .falseVariables(falseVariables)
       .deferredFragmentIdentifiers(deferredFragmentIds)
-      .errors(if (ignoreErrors) emptyList() else errors)
+      .errors(errors)
       .build()
   return adapter().nullable().fromJson(jsonReader, customScalarAdapters1)
 }