Skip to content

Commit b323879

Browse files
committed
Rename Defer20220824 protocol to GraphQL17Alpha2 fpr consistency
1 parent 48b18e4 commit b323879

File tree

10 files changed

+19
-19
lines changed

10 files changed

+19
-19
lines changed

libraries/apollo-api/src/commonMain/kotlin/com/apollographql/apollo/api/BooleanExpression.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ private fun shouldParseFragment(
9595
// Modern protocol: parse fragments that are _not_ pending
9696
!deferredFragmentIdentifiers.contains(identifier)
9797
} else {
98-
// Legacy 20220824 protocol: parse fragments that have been merged
98+
// Legacy GraphQL17Alpha2 protocol: parse fragments that have been merged
9999
deferredFragmentIdentifiers.contains(identifier)
100100
}
101101
}

libraries/apollo-runtime/api/android/apollo-runtime.api

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -366,7 +366,7 @@ public final class com/apollographql/apollo/network/http/HttpNetworkTransport$En
366366
}
367367

368368
public final class com/apollographql/apollo/network/http/HttpNetworkTransport$IncrementalDeliveryProtocol : java/lang/Enum {
369-
public static final field Defer20220824 Lcom/apollographql/apollo/network/http/HttpNetworkTransport$IncrementalDeliveryProtocol;
369+
public static final field GraphQL17Alpha2 Lcom/apollographql/apollo/network/http/HttpNetworkTransport$IncrementalDeliveryProtocol;
370370
public static final field GraphQL17Alpha9 Lcom/apollographql/apollo/network/http/HttpNetworkTransport$IncrementalDeliveryProtocol;
371371
public static fun getEntries ()Lkotlin/enums/EnumEntries;
372372
public static fun valueOf (Ljava/lang/String;)Lcom/apollographql/apollo/network/http/HttpNetworkTransport$IncrementalDeliveryProtocol;

libraries/apollo-runtime/api/apollo-runtime.klib.api

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -295,7 +295,7 @@ final class com.apollographql.apollo.network.http/HttpNetworkTransport : com.apo
295295
final fun newBuilder(): com.apollographql.apollo.network.http/HttpNetworkTransport.Builder // com.apollographql.apollo.network.http/HttpNetworkTransport.newBuilder|newBuilder(){}[0]
296296

297297
final enum class IncrementalDeliveryProtocol : kotlin/Enum<com.apollographql.apollo.network.http/HttpNetworkTransport.IncrementalDeliveryProtocol> { // com.apollographql.apollo.network.http/HttpNetworkTransport.IncrementalDeliveryProtocol|null[0]
298-
enum entry Defer20220824 // com.apollographql.apollo.network.http/HttpNetworkTransport.IncrementalDeliveryProtocol.Defer20220824|null[0]
298+
enum entry GraphQL17Alpha2 // com.apollographql.apollo.network.http/HttpNetworkTransport.IncrementalDeliveryProtocol.GraphQL17Alpha2|null[0]
299299
enum entry GraphQL17Alpha9 // com.apollographql.apollo.network.http/HttpNetworkTransport.IncrementalDeliveryProtocol.GraphQL17Alpha9|null[0]
300300

301301
final val entries // com.apollographql.apollo.network.http/HttpNetworkTransport.IncrementalDeliveryProtocol.entries|#static{}entries[0]

libraries/apollo-runtime/api/jvm/apollo-runtime.api

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -362,7 +362,7 @@ public final class com/apollographql/apollo/network/http/HttpNetworkTransport$En
362362
}
363363

364364
public final class com/apollographql/apollo/network/http/HttpNetworkTransport$IncrementalDeliveryProtocol : java/lang/Enum {
365-
public static final field Defer20220824 Lcom/apollographql/apollo/network/http/HttpNetworkTransport$IncrementalDeliveryProtocol;
365+
public static final field GraphQL17Alpha2 Lcom/apollographql/apollo/network/http/HttpNetworkTransport$IncrementalDeliveryProtocol;
366366
public static final field GraphQL17Alpha9 Lcom/apollographql/apollo/network/http/HttpNetworkTransport$IncrementalDeliveryProtocol;
367367
public static fun getEntries ()Lkotlin/enums/EnumEntries;
368368
public static fun valueOf (Ljava/lang/String;)Lcom/apollographql/apollo/network/http/HttpNetworkTransport$IncrementalDeliveryProtocol;
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,10 @@ import com.apollographql.apollo.api.IncrementalResultIdentifiers
55
import okio.BufferedSource
66

77
/**
8-
* Merger for the [com.apollographql.apollo.network.http.HttpNetworkTransport.IncrementalDeliveryProtocol.Defer20220824] protocol format.
8+
* Merger for the [com.apollographql.apollo.network.http.HttpNetworkTransport.IncrementalDeliveryProtocol.GraphQL17Alpha2] protocol format.
99
*/
1010
@Suppress("UNCHECKED_CAST")
11-
internal class Defer20220824IncrementalResultsMerger : IncrementalResultsMerger {
11+
internal class GraphQL17Alpha2IncrementalResultsMerger : IncrementalResultsMerger {
1212
private val _merged: MutableJsonMap = mutableMapOf()
1313
override val merged: JsonMap = _merged
1414

libraries/apollo-runtime/src/commonMain/kotlin/com/apollographql/apollo/internal/incremental/IncrementalDeliveryProtocolImpl.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ internal sealed interface IncrementalDeliveryProtocolImpl {
1818
object Defer20220824 : IncrementalDeliveryProtocolImpl {
1919
override val acceptHeader: String = "multipart/mixed;deferSpec=20220824, application/graphql-response+json, application/json"
2020

21-
override fun newIncrementalResultsMerger(): IncrementalResultsMerger = Defer20220824IncrementalResultsMerger()
21+
override fun newIncrementalResultsMerger(): IncrementalResultsMerger = GraphQL17Alpha2IncrementalResultsMerger()
2222
}
2323

2424
/**
@@ -37,6 +37,6 @@ internal sealed interface IncrementalDeliveryProtocolImpl {
3737

3838
internal val HttpNetworkTransport.IncrementalDeliveryProtocol.impl: IncrementalDeliveryProtocolImpl
3939
get() = when (this) {
40-
HttpNetworkTransport.IncrementalDeliveryProtocol.Defer20220824 -> IncrementalDeliveryProtocolImpl.Defer20220824
40+
HttpNetworkTransport.IncrementalDeliveryProtocol.GraphQL17Alpha2 -> IncrementalDeliveryProtocolImpl.Defer20220824
4141
HttpNetworkTransport.IncrementalDeliveryProtocol.GraphQL17Alpha9 -> IncrementalDeliveryProtocolImpl.GraphQL17Alpha9
4242
}

libraries/apollo-runtime/src/commonMain/kotlin/com/apollographql/apollo/network/http/HttpNetworkTransport.kt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -314,7 +314,7 @@ private constructor(
314314
private var engine: HttpEngine? = null
315315
private val interceptors: MutableList<HttpInterceptor> = mutableListOf()
316316
private var exposeErrorBody: Boolean = false
317-
private var incrementalDeliveryProtocol: IncrementalDeliveryProtocol = IncrementalDeliveryProtocol.Defer20220824
317+
private var incrementalDeliveryProtocol: IncrementalDeliveryProtocol = IncrementalDeliveryProtocol.GraphQL17Alpha2
318318
private val headers: MutableList<HttpHeader> = mutableListOf()
319319

320320
fun httpRequestComposer(httpRequestComposer: HttpRequestComposer) = apply {
@@ -361,7 +361,7 @@ private constructor(
361361
/**
362362
* The incremental delivery protocol to use when using `@defer` and/or `@stream`.
363363
*
364-
* Default: [IncrementalDeliveryProtocol.Defer20220824]
364+
* Default: [IncrementalDeliveryProtocol.GraphQL17Alpha2]
365365
*/
366366
@ApolloExperimental
367367
fun incrementalDeliveryProtocol(incrementalDeliveryProtocol: IncrementalDeliveryProtocol) = apply {
@@ -420,14 +420,14 @@ private constructor(
420420
enum class IncrementalDeliveryProtocol {
421421

422422
/**
423-
* Format specified in this historical commit:
423+
* Newer format as implemented by graphql.js version `17.0.0-alpha.2` and specified in this historical commit:
424424
* https://github.com/graphql/graphql-spec/tree/48cf7263a71a683fab03d45d309fd42d8d9a6659/spec
425425
*
426426
* Only `@defer` is supported with this format.
427427
*
428428
* This is the default.
429429
*/
430-
Defer20220824,
430+
GraphQL17Alpha2,
431431

432432
/**
433433
* Newer format as implemented by graphql.js version `17.0.0-alpha.9`.
Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import com.apollographql.apollo.annotations.ApolloInternal
66
import com.apollographql.apollo.api.DeferredFragmentIdentifier
77
import com.apollographql.apollo.api.json.BufferedSourceJsonReader
88
import com.apollographql.apollo.api.json.readAny
9-
import com.apollographql.apollo.internal.incremental.Defer20220824IncrementalResultsMerger
9+
import com.apollographql.apollo.internal.incremental.GraphQL17Alpha2IncrementalResultsMerger
1010
import okio.Buffer
1111
import kotlin.test.Test
1212
import kotlin.test.assertEquals
@@ -18,10 +18,10 @@ private fun String.buffer() = Buffer().writeUtf8(this)
1818
@Suppress("UNCHECKED_CAST")
1919
private fun jsonToMap(json: String): Map<String, Any?> = BufferedSourceJsonReader(json.buffer()).readAny() as Map<String, Any?>
2020

21-
class Defer20220824IncrementalResultsMergerTest {
21+
class GraphQL17Alpha2IncrementalResultsMergerTest {
2222
@Test
2323
fun mergeJsonSingleIncrementalItem() {
24-
val incrementalResultsMerger = Defer20220824IncrementalResultsMerger()
24+
val incrementalResultsMerger = GraphQL17Alpha2IncrementalResultsMerger()
2525

2626
//language=JSON
2727
val payload1 = """
@@ -392,7 +392,7 @@ class Defer20220824IncrementalResultsMergerTest {
392392

393393
@Test
394394
fun mergeJsonMultipleIncrementalItems() {
395-
val incrementalResultsMerger = Defer20220824IncrementalResultsMerger()
395+
val incrementalResultsMerger = GraphQL17Alpha2IncrementalResultsMerger()
396396

397397
//language=JSON
398398
val payload1 = """
@@ -668,7 +668,7 @@ class Defer20220824IncrementalResultsMergerTest {
668668

669669
@Test
670670
fun emptyPayloads() {
671-
val incrementalResultsMerger = Defer20220824IncrementalResultsMerger()
671+
val incrementalResultsMerger = GraphQL17Alpha2IncrementalResultsMerger()
672672

673673
//language=JSON
674674
val payload1 = """

tests/defer/src/commonTest/kotlin/test/Defer20220824NormalizedCacheTest.kt renamed to tests/defer/src/commonTest/kotlin/test/DeferGraphQL17Alpha2NormalizedCacheTest.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ import kotlin.test.assertFailsWith
4545
import kotlin.test.assertIs
4646
import kotlin.test.assertTrue
4747

48-
class Defer20220824NormalizedCacheTest {
48+
class DeferGraphQL17Alpha2NormalizedCacheTest {
4949
private lateinit var mockServer: MockServer
5050
private lateinit var apolloClient: ApolloClient
5151
private lateinit var store: ApolloStore

tests/defer/src/commonTest/kotlin/test/Defer20220824Test.kt renamed to tests/defer/src/commonTest/kotlin/test/DeferGraphQL17Alpha2Test.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ import kotlin.test.Test
2525
import kotlin.test.assertEquals
2626
import kotlin.test.assertTrue
2727

28-
class Defer20220824Test {
28+
class DeferGraphQL17Alpha2Test {
2929
private lateinit var mockServer: MockServer
3030
private lateinit var apolloClient: ApolloClient
3131

0 commit comments

Comments
 (0)