Disable service-loading ApolloCompilerPlugin (#6059)

* remove deprecated typealias and fail with error

* fix Gradle test

* use ApolloCompilerPluginProvider

Author: martinbonnin

libraries/apollo-compiler/src/main/kotlin/com/apollographql/apollo/compiler/ApolloCompilerPlugin.kt

@@ -11,13 +11,6 @@ import com.apollographql.apollo.compiler.ir.IrOperations
 import com.apollographql.apollo.compiler.operationoutput.OperationDescriptor
 import com.apollographql.apollo.compiler.operationoutput.OperationId
 
-@Deprecated(
-    "Use ApolloCompilerPlugin instead (don't forget to replace the META-INF.service file to `com.apollographql.apollo.compiler.ApolloCompilerPlugin`",
-    ReplaceWith("ApolloCompilerPlugin"),
-    DeprecationLevel.ERROR
-)
-typealias Plugin = ApolloCompilerPlugin
-
 /**
  * [ApolloCompilerPlugin] allows to customize the behaviour of the Apollo Compiler.
  *

libraries/apollo-gradle-plugin-external/src/main/kotlin/com/apollographql/apollo/gradle/internal/serviceloader.kt

@@ -19,7 +19,7 @@ internal fun apolloCompilerPlugin(
 
   val plugin = plugins.singleOrNull()
   if (plugin != null) {
-    return plugin
+    error("Apollo: use ApolloCompilerPluginProvider instead of ApolloCompilerPlugin directly. ApolloCompilerPluginProvider allows arguments and logging")
   }
 
   val pluginProviders = ServiceLoader.load(ApolloCompilerPluginProvider::class.java).toList()

libraries/apollo-gradle-plugin/testProjects/operationIdsWithIsolation/apollo-compiler-plugin/src/main/kotlin/apollo/plugin/MyPlugin.kt

@@ -1,12 +1,23 @@
 package apollo.plugin
 
+import com.apollographql.apollo.annotations.ApolloExperimental
 import com.apollographql.apollo.compiler.OperationOutputGenerator
 import com.apollographql.apollo.compiler.ApolloCompilerPlugin
+import com.apollographql.apollo.compiler.ApolloCompilerPluginEnvironment
+import com.apollographql.apollo.compiler.ApolloCompilerPluginProvider
 import com.apollographql.apollo.compiler.operationoutput.OperationDescriptor
 import com.apollographql.apollo.compiler.operationoutput.OperationId
 
 class MyPlugin: ApolloCompilerPlugin {
     override fun operationIds(descriptors: List<OperationDescriptor>): List<OperationId>? {
         return descriptors.map { OperationId("${it.name}CustomId", it.name) }
     }
+}
+
+@OptIn(ApolloExperimental::class)
+class MyPluginProvider: ApolloCompilerPluginProvider {
+    override fun create(environment: ApolloCompilerPluginEnvironment): ApolloCompilerPlugin {
+        return MyPlugin()
+    }
+
 }

libraries/apollo-gradle-plugin/testProjects/operationIdsWithIsolation/apollo-compiler-plugin/src/main/resources/META-INF/services/com.apollographql.apollo.compiler.ApolloCompilerPlugin

@@ -0,0 +1 @@
+apollo.plugin.MyPluginProvider

libraries/apollo-gradle-plugin/testProjects/operationIdsWithIsolation/apollo-compiler-plugin/src/main/resources/META-INF/services/com.apollographql.apollo.compiler.ApolloCompilerPluginProvider

@@ -13,6 +13,14 @@ import com.apollographql.apollo.ast.responseName
 import com.apollographql.apollo.ast.rootTypeDefinition
 import com.apollographql.apollo.compiler.DocumentTransform
 import com.apollographql.apollo.compiler.ApolloCompilerPlugin
+import com.apollographql.apollo.compiler.ApolloCompilerPluginEnvironment
+import com.apollographql.apollo.compiler.ApolloCompilerPluginProvider
+
+class TestPluginProvider: ApolloCompilerPluginProvider {
+  override fun create(environment: ApolloCompilerPluginEnvironment): ApolloCompilerPlugin {
+    return TestPlugin()
+  }
+}
 
 class TestPlugin : ApolloCompilerPlugin {
   override fun documentTransform(): DocumentTransform {

tests/compiler-plugins/add-field/src/main/kotlin/hooks/TestPlugin.kt

@@ -0,0 +1 @@
+hooks.TestPluginProvider

tests/compiler-plugins/add-field/src/main/resources/META-INF/services/com.apollographql.apollo.compiler.ApolloCompilerPlugin

@@ -1,11 +1,19 @@
 package hooks
 
 import com.apollographql.apollo.compiler.ApolloCompilerPlugin
+import com.apollographql.apollo.compiler.ApolloCompilerPluginEnvironment
+import com.apollographql.apollo.compiler.ApolloCompilerPluginProvider
 import com.apollographql.apollo.compiler.Transform
 import com.apollographql.apollo.compiler.codegen.kotlin.KotlinOutput
 import com.squareup.kotlinpoet.FunSpec
 import com.squareup.kotlinpoet.TypeSpec
 
+class TestPluginProvider: ApolloCompilerPluginProvider {
+  override fun create(environment: ApolloCompilerPluginEnvironment): ApolloCompilerPlugin {
+    return TestPlugin()
+  }
+}
+
 class TestPlugin : ApolloCompilerPlugin {
   override fun kotlinOutputTransform(): Transform<KotlinOutput> {
     return object : Transform<KotlinOutput> {