Operation Collections - fix update checking (#146)

* fix update checking

* add changeset

* early return

Author: Jephuff

.changesets/fix_jeffrey_fix_collection_update_checking.md

@@ -0,0 +1,3 @@
+### Fix tool update on every poll - @Jephuff PR #146
+
+Only update the tool list if an operation was removed, changed, or added.

crates/apollo-mcp-registry/src/platform_api/operation_collections/collection_poller.rs

@@ -60,12 +60,11 @@ async fn handle_poll_result(
     poll: Vec<(String, String)>,
     platform_api_config: &PlatformApiConfig,
 ) -> Result<Option<Vec<OperationData>>, CollectionError> {
-    let mut keep_ids = poll.iter().map(|(id, _)| id);
-    for id in previous_updated_at.clone().keys() {
-        if keep_ids.all(|keep_id| keep_id != id) {
-            previous_updated_at.remove(id);
-        }
-    }
+    let removed_ids = previous_updated_at.clone();
+    let removed_ids = removed_ids
+        .keys()
+        .filter(|id| poll.iter().all(|(keep_id, _)| keep_id != *id))
+        .collect::<Vec<_>>();
 
     let changed_ids: Vec<String> = poll
         .into_iter()
@@ -77,11 +76,20 @@ async fn handle_poll_result(
         })
         .collect();
 
-    if changed_ids.is_empty() {
+    if changed_ids.is_empty() && removed_ids.is_empty() {
         tracing::debug!("no operation changed");
-        Ok(None)
-    } else {
-        tracing::debug!("changed operation ids: {:?}", changed_ids);
+        return Ok(None);
+    }
+
+    if !removed_ids.is_empty() {
+        tracing::info!("removed operation ids: {:?}", removed_ids);
+        for id in removed_ids {
+            previous_updated_at.remove(id);
+        }
+    }
+
+    if !changed_ids.is_empty() {
+        tracing::info!("changed operation ids: {:?}", changed_ids);
         let full_response = graphql_request::<OperationCollectionEntriesQuery>(
             &OperationCollectionEntriesQuery::build_query(
                 operation_collection_entries_query::Variables {
@@ -91,16 +99,15 @@ async fn handle_poll_result(
             platform_api_config,
         )
         .await?;
-
         for operation in full_response.operation_collection_entries {
             previous_updated_at.insert(
                 operation.id.clone(),
                 OperationData::from(&operation).clone(),
             );
         }
-
-        Ok(Some(previous_updated_at.clone().into_values().collect()))
     }
+
+    Ok(Some(previous_updated_at.clone().into_values().collect()))
 }
 
 #[derive(Clone)]