PR feedback

Author: swcollard

crates/apollo-mcp-server/src/runtime/telemetry.rs

@@ -50,9 +50,13 @@ pub enum MetricTemporality {
     Delta,
 }
 
-impl MetricTemporality {
-    pub fn to_sdk(&self) -> Temporality {
-        match self {
+impl OTLPMetricExporter {
+    pub fn to_temporality(&self) -> Temporality {
+        match self
+            .temporality
+            .as_ref()
+            .unwrap_or(&MetricTemporality::Cumulative)
+        {
             MetricTemporality::Cumulative => Temporality::Cumulative,
             MetricTemporality::Delta => Temporality::Delta,
         }
@@ -63,15 +67,15 @@ impl MetricTemporality {
 pub struct OTLPMetricExporter {
     endpoint: String,
     protocol: String,
-    temporality: MetricTemporality,
+    temporality: Option<MetricTemporality>,
 }
 
 impl Default for OTLPMetricExporter {
     fn default() -> Self {
         Self {
             endpoint: "http://localhost:4317".into(),
             protocol: "grpc".into(),
-            temporality: MetricTemporality::Cumulative,
+            temporality: Some(MetricTemporality::Cumulative),
         }
     }
 }
@@ -139,12 +143,12 @@ fn init_meter_provider(telemetry: &Telemetry) -> Result<SdkMeterProvider, anyhow
         "grpc" => opentelemetry_otlp::MetricExporter::builder()
             .with_tonic()
             .with_endpoint(otlp.endpoint.clone())
-            .with_temporality(otlp.temporality.to_sdk())
+            .with_temporality(otlp.to_temporality())
             .build()?,
         "http/protobuf" => opentelemetry_otlp::MetricExporter::builder()
             .with_http()
             .with_endpoint(otlp.endpoint.clone())
-            .with_temporality(otlp.temporality.to_sdk())
+            .with_temporality(otlp.to_temporality())
             .build()?,
         other => {
             return Err(anyhow::anyhow!(
@@ -350,7 +354,7 @@ mod tests {
                 otlp: Some(OTLPMetricExporter {
                     protocol: "bogus".to_string(),
                     endpoint: "http://localhost:4317".to_string(),
-                    temporality: MetricTemporality::Cumulative,
+                    temporality: None,
                 }),
                 omitted_attributes: None,
             }),
@@ -374,7 +378,7 @@ mod tests {
                 otlp: Some(OTLPMetricExporter {
                     protocol: "http/protobuf".to_string(),
                     endpoint: "http://localhost:4318/v1/metrics".to_string(),
-                    temporality: MetricTemporality::Delta,
+                    temporality: Some(MetricTemporality::Delta),
                 }),
                 omitted_attributes: None,
             }),

docs/source/config-file.mdx

@@ -252,19 +252,11 @@ transport:
 
 #### OTLP Metrics Exporter
 
-| Option        | Type          | Default                     | Description                                                                                                                                                               |
-| :---------    | :------------ | :-------------------------- | :------------------------------------------------------------------------------------------------------------------------------------------------------------------------ |
-| `endpoint`    | `URL`         | `http://localhost:4137`     | URL to export data to. Requires full path.                                                                                                                                |
-| `protocol`    | `string`      | `grpc`                      | Protocol for export. Only `grpc` and `http/protobuf` are supported.                                                                                                       |
-| `temporality` | `Temporality` | `Cumulative`                | OTel property that refers to the way additive quantities are expressed, in relation to time, indicating whether reported values incorporate previous measurements or not. |
-
-##### Temporality
-
-| Option       | Type    | Description                                                                                       |
-| :----------- | :------ | :------------------------------------------------------------------------------------------------ |
-| `Cumulative` | `enum`  | The metric value will be the overall value since the start of the measurement. (default behavior) |
-| `Delta`      | `enum`  | The metric will be the difference in the measurement since the last time it was reported.         |
-
+| Option        | Type                                     | Default                  | Description                                                                                                                                                                                             |
+| :---------    | :--------------------------------------- | :----------------------- | :------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ |
+| `endpoint`    | `URL`                                    | `http://localhost:4137`  | URL to export data to. Requires full path.                                                                                                                                                              |
+| `protocol`    | `string`                                 | `grpc`                   | Protocol for export. Only `grpc` and `http/protobuf` are supported.                                                                                                                                     |
+| `temporality` | `Optional oneOf ["Cumulative", "Delta"]` | `Cumulative`             | Optional OTel property that refers to the way additive quantities are expressed, in relation to time, indicating whether reported values incorporate previous measurements (Cumulative) or not (Delta). |
 
 #### Traces