editor pre-prepare

Author: abernix

.changesets/config_caroline_remove_unused_ttl.md

@@ -1,6 +1,7 @@
-### Remove unused TTL parameter from response cache Redis config ([PR #8513](https://github.com/apollographql/router/pull/8513))
+### Remove unused TTL parameter from response cache Redis configuration ([PR #8513](https://github.com/apollographql/router/pull/8513))
 
 The `ttl` parameter under `redis` configuration had no effect and is removed. Configure TTL at the `subgraph` level to control cache entry expiration:
+
 ```yaml
 preview_response_cache:
   enabled: true

.changesets/docs_caroline_router_1509.md

@@ -1,5 +1,5 @@
-### Add Redis cache suggestions to the response cache documentation ([PR #8624](https://github.com/apollographql/router/pull/8624))
+### Add Redis cache suggestions to response cache documentation ([PR #8624](https://github.com/apollographql/router/pull/8624))
 
-Several questions have been added to the FAQ, specifically overing the supported Redis versions and how to set up Redis key eviction.
+The FAQ now includes information about supported Redis versions and Redis key eviction setup.
 
 By [@carodewig](https://github.com/carodewig) in https://github.com/apollographql/router/pull/8624

.changesets/docs_fix_doc_active_subgraph_requests.md

@@ -1,37 +1,5 @@
-### feat(telemetry): add active subgraph requests attribute to router ove… ([PR #8530](https://github.com/apollographql/router/pull/8530))
+### Document active subgraph requests selector ([PR #8530](https://github.com/apollographql/router/pull/8530))
 
-Modified the selectors section to reflect the `active_subgraph_requests` properly
-
-<!-- start metadata -->
-
-<!-- [ROUTER-####] -->
----
-
-**Checklist**
-
-Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
-
-- [ ] PR description explains the motivation for the change and relevant context for reviewing
-- [ ] PR description links appropriate GitHub/Jira tickets (creating when necessary)
-- [ ] Changeset is included for user-facing changes
-- [ ] Changes are compatible[^1]
-- [ ] Documentation[^2] completed
-- [ ] Performance impact assessed and acceptable
-- [ ] Metrics and logs are added[^3] and documented
-- Tests added and passing[^4]
-    - [ ] Unit tests
-    - [ ] Integration tests
-    - [ ] Manual tests, as necessary
-
-**Exceptions**
-
-*Note any exceptions here*
-
-**Notes**
-
-[^1]: It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.
-[^2]: Configuration is an important part of many changes. Where applicable please try to document configuration examples.
-[^3]: A lot of (if not most) features benefit from built-in observability and `debug`-level logs. Please read [this guidance](https://github.com/apollographql/router/blob/dev/dev-docs/metrics.md#adding-new-metrics) on metrics best-practices.
-[^4]: Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.
+The telemetry selectors documentation now correctly reflects the `active_subgraph_requests` attribute.
 
 By [@faisalwaseem](https://github.com/faisalwaseem) in https://github.com/apollographql/router/pull/8530

.changesets/feat_aaron_http2_header_list_size.md

@@ -1,6 +1,6 @@
-### Configure maximum allowed HTTP/2 header list size ([PR #8636](https://github.com/apollographql/router/pull/8636))
+### Configure maximum HTTP/2 header list size ([PR #8636](https://github.com/apollographql/router/pull/8636))
 
-The router now supports configuring the maximum size allowed for HTTP/2 header lists via the `limits.http2_max_headers_list_bytes` setting. This protects against excessive resource usage from clients sending extremely large sets of HTTP/2 headers.
+The router now supports configuring the maximum size for HTTP/2 header lists via the `limits.http2_max_headers_list_bytes` setting. This protects against excessive resource usage from clients sending large sets of HTTP/2 headers.
 
 The default remains 16KiB. When a client sends a request with HTTP/2 headers whose total size exceeds the configured limit, the router rejects the request with a 431 error code.
 

.changesets/feat_bnjjj_router_1506.md

@@ -1,8 +1,8 @@
-### Add selectors for telemetry to create metrics based on cache-control values ([PR #8524](https://github.com/apollographql/router/pull/8524))
+### Add telemetry selector for Cache-Control metrics ([PR #8524](https://github.com/apollographql/router/pull/8524))
 
-New selector `response_cache_control` added in telemetry for subgraph service to know what's the content of the computed [`Cache-Control` header](https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Headers/Cache-Control) from the subgraph response.
+The new `response_cache_control` selector enables telemetry metrics based on the computed [`Cache-Control` header](https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Headers/Cache-Control) from subgraph responses.
 
-Example of attributes added to metrics:
+**Example configuration:**
 
 ```yaml
 telemetry:
@@ -11,10 +11,10 @@ telemetry:
       common:
         service_name: apollo-router
         views:
-          - name: subgraph.response.cache_control.max_age # This is to make sure it will use the correct buckets for the max age histogram
+          - name: subgraph.response.cache_control.max_age
             aggregation:
               histogram:
-                buckets: # Override default buckets configured for this histogram
+                buckets:
                 - 10
                 - 100
                 - 1000
@@ -27,7 +27,7 @@ telemetry:
           value:
             response_cache_control: max_age
           type: histogram
-          unit: s # Seconds
+          unit: s
           description: A histogram of the computed TTL for a subgraph response
 ```
 

.changesets/feat_bnjjj_router_1517.md

@@ -1,23 +1,23 @@
-### Response caching: support customizing cache key per subgraph via context ([PR #8543](https://github.com/apollographql/router/pull/8543))
+### Customize response cache key per subgraph via context ([PR #8543](https://github.com/apollographql/router/pull/8543))
 
-The response cache key can be customized by the context entry `apollo::response_cache::key`. Previously, customization was supported per operation name or for all subgraph requests. This change introduces the ability to customize cache keys for individual subgraphs by using the new `subgraphs` field, where you can define separate entries for each subgraph name. 
+The response cache key can now be customized per subgraph using the `apollo::response_cache::key` context entry. The new `subgraphs` field enables defining separate cache keys for individual subgraphs.
 
-Please note that data for a specific subgraph takes precedence over data in the `all` field, and the router doesn't merge data between them. To set common data when providing subgraph-specific data, add it to the subgraph-specific section.
+Subgraph-specific data takes precedence over data in the `all` field—the router doesn't merge them. To set common data when providing subgraph-specific data, add it to the subgraph-specific section.
 
-Example payload:
+**Example payload:**
 
 ```json
 {
-    "all": 1,
-    "subgraph_operation1": "key1",
-    "subgraph_operation2": {
-      "data": "key2"
-    },
-    "subgraphs": {
-      "my_subgraph": {
-        "locale": "be"
-      }
+  "all": 1,
+  "subgraph_operation1": "key1",
+  "subgraph_operation2": {
+    "data": "key2"
+  },
+  "subgraphs": {
+    "my_subgraph": {
+      "locale": "be"
     }
+  }
 }
 ```
 

.changesets/feat_tylerb_cors_private_network_access.md

@@ -1,6 +1,8 @@
-### CORS Private Network Access support ([PR #8279](https://github.com/apollographql/router/pull/8279))
+### Add CORS Private Network Access support ([PR #8279](https://github.com/apollographql/router/pull/8279))
 
-Expands CORS configuration and support for the [private network access](https://wicg.github.io/private-network-access/) (PNA) feature in CORS. To enable PNA for a CORS policy in configuration, specify the field `private_network_access`. The `private_network_access` field has two subfields, `access_id` and `access_name`, both of which are optional.
+CORS configuration now supports [private network access](https://wicg.github.io/private-network-access/) (PNA). Enable PNA for a CORS policy by specifying the `private_network_access` field, which supports two optional subfields: `access_id` and `access_name`.
+
+**Example configuration:**
 
 ```yaml
 cors:

.changesets/fix_caroline_combine_error_types.md

@@ -1,8 +1,5 @@
-### unify timeout codes in response caching metrics ([PR #8515](https://github.com/apollographql/router/pull/8515))
+### Unify timeout codes in response caching metrics ([PR #8515](https://github.com/apollographql/router/pull/8515))
 
-Unify the 'timeout' code used as a parameter in `apollo.router.operations.response_cache.*.error` metrics.
-
-Tokio- and Redis-based timeouts should be treated as the same thing for the purpose of monitoring, but they were
-inadvertently given different code values.
+Tokio- and Redis-based timeouts now use the same `timeout` code in `apollo.router.operations.response_cache.*.error` metrics. Previously, they were inadvertently given different code values.
 
 By [@carodewig](https://github.com/carodewig) in https://github.com/apollographql/router/pull/8515

.changesets/fix_linen_smooth_rudder_awaken.md

@@ -1,7 +1,7 @@
-### Fix missing Content-Length header  ([Issue](https://github.com/apollographql/router/issues/7941))
+### Preserve Content-Length header for responses with known size ([Issue #7941](https://github.com/apollographql/router/issues/7941))
 
-Apollo Router was using `transfer-encoding: chunked` for GraphQL responses with known content lengths instead of the more efficient content-length header due to the fleet_detector plugin destroying HTTP body size hints when collecting metrics.
+The router now uses the `Content-Length` header for GraphQL responses with known content lengths instead of `transfer-encoding: chunked`. Previously, the `fleet_detector` plugin destroyed HTTP body size hints when collecting metrics.
 
-In https://github.com/apollographql/router/pull/6538 we solved this same issue for metrics for the `router -> subgraph` by modifying the fleet_detector plugin to preserve size hints for bodies with known content lengths by checking `size_hint.exact()` and only wrapping unknown-size bodies in streams for byte counting. This PR extends the existing fix already applied to `router → subgraph` requests to also cover `client → router` requests/responses, ensuring size hints flow correctly through the entire pipeline for optimal HTTP header selection.
+This extends the fix from [#6538](https://github.com/apollographql/router/pull/6538), which preserved size hints for `router → subgraph` requests, to also cover `client → router` requests and responses. Size hints now flow correctly through the entire pipeline for optimal HTTP header selection.
 
 By [@morriswchris](https://github.com/morriswchris) in https://github.com/apollographql/router/pull/7977

.changesets/fix_rohan_b99_apollo_router_operations_subscriptions_events_incorrect.md

@@ -1,6 +1,7 @@
-### Fix `apollo.router.operations.subscriptions.events` metric not incrementing for subscription events ([PR #8483](https://github.com/apollographql/router/pull/8483))
+### Correct `apollo.router.operations.subscriptions.events` metric counting ([PR #8483](https://github.com/apollographql/router/pull/8483))
 
-Moves the `u64_counter!` call into the stream so it triggers for each subscription event (ignoring ping/pong/close etc).
-Also removes the custom sending of pong responses before connection ack is received, which resulted in 2 pongs being sent as the websocket implementation already replies to pings by default.
+The `apollo.router.operations.subscriptions.events` metric now increments correctly for each subscription event (excluding ping/pong/close messages). The counter call has been moved into the stream to trigger on each event.
+
+This change also removes custom pong response handling before connection acknowledgment, which previously caused duplicate pongs because the WebSocket implementation already handles pings by default.
 
 By [@rohan-b99](https://github.com/rohan-b99) in https://github.com/apollographql/router/pull/8483