chore(composition): Make assert_composition_errors a strict equality check (#8706)

Author: tninesling

apollo-federation/tests/composition/compose_directive_sharing.rs

@@ -311,7 +311,7 @@ fn field_sharing_applies_shareable_on_type_only_to_fields_within_definition() {
         &result,
         &[(
             "INVALID_FIELD_SHARING",
-            r#"Non-shareable field "A.x" is resolved from multiple subgraphs"#,
+            r#"Non-shareable field "A.x" is resolved from multiple subgraphs: it is resolved from subgraphs "subgraphA" and "subgraphB" and defined as non-shareable in subgraph "subgraphB""#,
         )],
     );
 }
@@ -454,7 +454,7 @@ fn interface_object_field_requires_shareable() {
         &result,
         &[(
             "INVALID_FIELD_SHARING",
-            r#"Non-shareable field "Entity.sku" is resolved from multiple subgraphs"#,
+            r#"Non-shareable field "Entity.sku" is resolved from multiple subgraphs: it is resolved from subgraphs "subgraphA", "subgraphB (through @interfaceObject field "Node.sku")" and "subgraphC" and defined as non-shareable in subgraph "subgraphB (through @interfaceObject field "Node.sku")""#,
         )],
     );
 }

apollo-federation/tests/composition/compose_validation.rs

@@ -39,7 +39,8 @@ fn merge_validations_errors_when_a_subgraph_is_invalid() {
  3 │           a: A
    │              ┬  
    │              ╰── not found in this scope
-───╯"#,
+───╯
+"#,
         )],
     );
 }
@@ -75,7 +76,8 @@ fn merge_validations_errors_when_subgraph_has_introspection_reserved_name() {
  3 │           __someQuery: Int
    │           ─────┬─────  
    │                ╰─────── Pick a different name here
-───╯"#,
+───╯
+"#,
         )],
     );
 }

apollo-federation/tests/composition/mod.rs

@@ -116,16 +116,16 @@ pub(crate) mod test_helpers {
 
             // Check error code
             assert!(
-                error_code.contains(expected_code),
-                "Error at index {} does not contain expected code.\n\nEXPECTED:\n{}\nACTUAL:\n{}",
+                error_code == expected_code,
+                "Error at index {} does not equal expected code.\n\nEXPECTED:\n{}\nACTUAL:\n{}",
                 i,
                 format_args!("code: {}\nmessage: {}\n", expected_code, expected_message),
                 format_args!("code: {}\nmessage: {}\n", error_code, error_str)
             );
             // Check error message
             assert!(
-                error_str.contains(expected_message),
-                "Error at index {} does not contain expected message.\n\nEXPECTED:\n{}\nACTUAL:\n{}",
+                error_str == expected_message,
+                "Error at index {} does not equal expected message.\n\nEXPECTED:\n{}\nACTUAL:\n{}",
                 i,
                 format_args!("code: {}\nmessage: {}\n", expected_code, expected_message),
                 format_args!("code: {}\nmessage: {}\n", error_code, error_str)