HELP! Upgrade to 0.9.4: how to handle RouterResponse<BoxStream<'static, ResponseBody>> compile errors???? #1249
-
|
I had to update to 0.9.4 to get the fix for the clap issue.. I have a plugin that is working with the RouterResponse and now it won't work... the old code looks like this and now that the RouterResponse object has changed, i don't know how to handle.. see compile errors below .map_response(|mut resp:RouterResponse| {
let mut debug_query = false;
if let Ok(Some(data)) = resp.context.get::<_, bool>("graphDebug") {
debug_query = data;
}
if (debug_query) {
log::info!(target: "app::debug", "Final Response: {:?}", resp);
log::info!(target: "app::debug", "Final Response: {:?}", resp.response.body());
log::info!(target: "app::debug", "Final Response Headers: {:?}", resp.response.headers());
log::info!(target: "app::debug", "Final Response: {:?}", resp.context);
}
// do any Set-Cookies for response
if let Ok(Some(data)) = resp.context.get::<_, CookieContext>("cookie_context") {
if (data.has_set_cookies) {
let mut set_cookie_offset = 0;
for existing_set_cookie in data.response_set_cookies {
match existing_set_cookie {
Some(value) => {
let hv = HeaderValue::from_str(&value).unwrap();
resp.response.headers_mut().append("Set-Cookie", hv);
},
None => {}
}
set_cookie_offset += 1;
}
}
}
let transaction_id = resp.context.get::<_, String>("transaction_id").unwrap().unwrap_or("bugaboo".to_string()).to_string();
if let Ok(Some(mut timer)) = resp.context.get::<_, GraphTimer>(&transaction_id) {
timer.status = Some(resp.response.status().as_u16());
match resp.response.body() {
ResponseBody::RawJSON(_) => {}
ResponseBody::GraphQL(res) => {
match &res.data {
Some(data) => timer.len = Some(data.to_string().len() as u64),
None => ()
}
}
ResponseBody::Text(_) => {}
}
timer.print_timer();
} |
Beta Was this translation helpful? Give feedback.
Replies: 2 comments 10 replies
-
|
ping o0Ignition0o |
Beta Was this translation helpful? Give feedback.
-
|
all i'm trying to do is to get the size of the response... is there another way to do it??? |
Beta Was this translation helpful? Give feedback.
-
|
Sure, I'll try to write an example that showcases this! In the meantime, you can revert to v0.9.3 if you pin the dependency to clap: apollo-router = { git = "https://github.com/apollographql/router.git", tag = "v0.9.3" }
clap = "=3.1.18"Let me know if pinning the dependency worked for you, and I'll be happy to provide better examples soon! |
Beta Was this translation helpful? Give feedback.
-
|
I think i have a workaround for getting the length... I really want to upgrade because the api has changed and i'll end up having to do it so i can get upcoming enhancements |
Beta Was this translation helpful? Give feedback.
-
|
My workound would work except the whole execution order got flipped around where the map_response is called prior to subgraph execution... this is not a good thing.... and basically a show stopper... |
Beta Was this translation helpful? Give feedback.
-
fn router_service(
&mut self,
service: BoxService<
RouterRequest,
RouterResponse<BoxStream<'static, ResponseBody>>,
BoxError,
>,
) -> BoxService<RouterRequest, RouterResponse<BoxStream<'static, ResponseBody>>, BoxError> {
ServiceBuilder::new()
.service(service)
.map_response(|router_response| {
if let Ok(Some(true)) = router_response.context.get::<_, bool>("debug") {
tracing::info!("debug mode!");
// let's play with the headers!
let headers = router_response
.response
.headers()
.iter()
.map(|(key, value)| format!("{}: {:?}", key.to_string(), value))
.collect::<Vec<_>>()
.join(" ");
tracing::info!("headers are: {:?}", headers);
// we can now transform the router_response!
router_response
.map(|response| {
response.map(|body| {
tracing::info!("got body! {:?}", body);
body
})
})
.boxed()
} else {
router_response.boxed()
}
})
.boxed()
}is an attempt to log the body, which I ll clean up tomorrow. It should be helpful in the meantime. I paired it with fn execution_service(
&mut self,
service: BoxService<
ExecutionRequest,
ExecutionResponse<BoxStream<'static, Response>>,
BoxError,
>,
) -> BoxService<ExecutionRequest, ExecutionResponse<BoxStream<'static, Response>>, BoxError>
{
ServiceBuilder::new()
.service(service)
.map_response(|response| {
response.context.insert("debug", true).unwrap();
response
})
.boxed()
}and the logs show that I'm in debug mode, which means the execution service has inserted "true" in the context: Happy to elaborate and work out a cleaner example tomorrow, in the meantime you can see the example I'm using for local tests in this repository I hope it helps! |
Beta Was this translation helpful? Give feedback.
-
|
This repository provides you with a working example of stream management, with more advanced things such as dealing with context |
Beta Was this translation helpful? Give feedback.
This repository provides you with a working example of stream management, with more advanced things such as dealing with context