-
Notifications
You must be signed in to change notification settings - Fork 327
docs: Point Federation Version Support doc to Changelog #8689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
In order to reduce the need for multiple updates over time, this change removes a table (which had become outdated) in favor of a link to the official changelog and how to use it for the same purpose the table had served.
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 0 new, 7 changed, 0 removedBuild ID: d34917030466bcc62219fb68 URL: https://www.apollographql.com/docs/deploy-preview/d34917030466bcc62219fb68 |
|
@jcaudle, please consider creating a changeset entry in |
Updated section heading since there is no "support table" anymore.
mabuyo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestions!
mabuyo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is a docs-only change but I tagged the Router Core team as reviewers in case they have any concerns to removing the table!
abernix
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big fan. Thanks! Can we also search the repo for other places we discuss federation-version-support and update/remove those? There's probably some places in the runbook (like the one that has been obviously ignored since we introduced more automation), but should still be removed.
Because the Federation Version Support document for Router no longer has a table of supported versions, that document no longer needs to be manually updated when preparing a release of Router.
Instead of directing readers to a document which will redirect them somewhere else (as the version table has been removed), these instructions now point readers directly to the Apollo Federation Changelog.
|
Great call @abernix. In addition to |
In order to reduce the need for multiple updates over time, this change removes a table (which had become outdated) in favor of a link to the official changelog and how to use it for the same purpose the table had served.