Skip to content

Conversation

@aaronArinder
Copy link
Contributor

@aaronArinder aaronArinder commented Dec 5, 2025


I started with a usize for the value of the http2 header config option and moved to a ByteSize without updating the key name; so, updated, and backfilling docs (for some reason assumed these were auto-generated)

⚠️ this is technically a breaking change from what was introduced in 2.8.x; I only think one customer is is experimenting with it, but be careful if you're thinking of backporting it

Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • PR description explains the motivation for the change and relevant context for reviewing
  • PR description links appropriate GitHub/Jira tickets (creating when necessary)
  • Changeset is included for user-facing changes
  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Metrics and logs are added3 and documented
  • Tests added and passing4
    • Unit tests
    • Integration tests
    • Manual tests, as necessary

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. A lot of (if not most) features benefit from built-in observability and debug-level logs. Please read this guidance on metrics best-practices.

  4. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@aaronArinder aaronArinder requested review from a team as code owners December 5, 2025 19:28
@apollo-librarian
Copy link

apollo-librarian bot commented Dec 5, 2025

✅ Docs preview ready

The preview is ready to be viewed. View the preview

File Changes

0 new, 4 changed, 0 removed
* graphos/routing/(latest)/observability/router-telemetry-otel/enabling-telemetry/instruments.mdx
* graphos/routing/(latest)/security/request-limits.mdx
* graphos/routing/(latest)/self-hosted/managed-hosting/railway.mdx
* graphos/routing/(latest)/self-hosted/managed-hosting/render.mdx

Build ID: 9b48e6580fff06ec8eed66a8
Build Logs: View logs

URL: https://www.apollographql.com/docs/deploy-preview/9b48e6580fff06ec8eed66a8

@github-actions

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants