Skip to content

Commit d152446

Browse files
committed
use Trailblazer::Core::Utils.inspect for future compat tests.
1 parent e0c91c0 commit d152446

File tree

7 files changed

+34
-23
lines changed

7 files changed

+34
-23
lines changed

declarative.gemspec

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,4 +22,5 @@ Gem::Specification.new do |spec|
2222
spec.add_development_dependency "rake"
2323
spec.add_development_dependency "minitest"
2424
spec.add_development_dependency "minitest-line"
25+
spec.add_development_dependency "trailblazer-core-utils"
2526
end

test/defaults_test.rb

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ class DefaultsOptionsTest < Minitest::Spec
1515
schema.add :author_name
1616
schema.add :description, _defaults: defaults
1717

18-
_(schema.inspect).must_equal '{"title"=>#<Declarative::Definitions::Definition: @options={:render_nil=>true, :as=>"TITLE", :name=>"title"}>, "author_name"=>#<Declarative::Definitions::Definition: @options={:name=>"author_name"}>, "description"=>#<Declarative::Definitions::Definition: @options={:render_nil=>true, :as=>"DESCRIPTION", :name=>"description"}>}'
18+
assert_equal CU.inspect(schema), %({"title"=>#<Declarative::Definitions::Definition: @options={:render_nil=>true, :as=>"TITLE", :name=>"title"}>, "author_name"=>#<Declarative::Definitions::Definition: @options={:name=>"author_name"}>, "description"=>#<Declarative::Definitions::Definition: @options={:render_nil=>true, :as=>"DESCRIPTION", :name=>"description"}>})
1919
end
2020
end
2121

@@ -29,7 +29,7 @@ class DefaultsOptionsTest < Minitest::Spec
2929
schema.add :author_name
3030
schema.add :description, _defaults: defaults
3131

32-
_(schema.inspect).must_equal '{"title"=>#<Declarative::Definitions::Definition: @options={:as=>"TITLE", :name=>"title"}>, "author_name"=>#<Declarative::Definitions::Definition: @options={:name=>"author_name"}>, "description"=>#<Declarative::Definitions::Definition: @options={:as=>"DESCRIPTION", :name=>"description"}>}'
32+
assert_equal CU.inspect(schema), %({"title"=>#<Declarative::Definitions::Definition: @options={:as=>"TITLE", :name=>"title"}>, "author_name"=>#<Declarative::Definitions::Definition: @options={:name=>"author_name"}>, "description"=>#<Declarative::Definitions::Definition: @options={:as=>"DESCRIPTION", :name=>"description"}>})
3333
end
3434
end
3535

@@ -41,7 +41,7 @@ class DefaultsOptionsTest < Minitest::Spec
4141
schema.add :author_name
4242
schema.add :description, _defaults: defaults
4343

44-
_(schema.inspect).must_equal '{"title"=>#<Declarative::Definitions::Definition: @options={:render_nil=>true, :name=>"title"}>, "author_name"=>#<Declarative::Definitions::Definition: @options={:name=>"author_name"}>, "description"=>#<Declarative::Definitions::Definition: @options={:render_nil=>true, :name=>"description"}>}'
44+
assert_equal CU.inspect(schema), %({"title"=>#<Declarative::Definitions::Definition: @options={:render_nil=>true, :name=>"title"}>, "author_name"=>#<Declarative::Definitions::Definition: @options={:name=>"author_name"}>, "description"=>#<Declarative::Definitions::Definition: @options={:render_nil=>true, :name=>"description"}>})
4545
end
4646
end
4747

@@ -55,7 +55,7 @@ class DefaultsOptionsTest < Minitest::Spec
5555
schema.add :author_name
5656
schema.add :description, _defaults: defaults
5757

58-
_(schema.inspect).must_equal '{"title"=>#<Declarative::Definitions::Definition: @options={:render_nil=>true, :as=>"Title", :name=>"title"}>, "author_name"=>#<Declarative::Definitions::Definition: @options={:name=>"author_name"}>, "description"=>#<Declarative::Definitions::Definition: @options={:render_nil=>true, :as=>"DESCRIPTION", :name=>"description"}>}'
58+
assert_equal CU.inspect(schema), %({"title"=>#<Declarative::Definitions::Definition: @options={:render_nil=>true, :as=>"Title", :name=>"title"}>, "author_name"=>#<Declarative::Definitions::Definition: @options={:name=>"author_name"}>, "description"=>#<Declarative::Definitions::Definition: @options={:render_nil=>true, :as=>"DESCRIPTION", :name=>"description"}>})
5959
end
6060
end
6161

@@ -65,15 +65,15 @@ class DefaultsOptionsTest < Minitest::Spec
6565
defaults.merge!(a: 1, b: 2)
6666
defaults.merge!( b: 3, _features: Declarative::Variables::Append(["A"]) )
6767
defaults.merge!( _features: Declarative::Variables::Append(["B", "C"]) )
68-
_(defaults.(nil, {}).inspect).must_equal "{:a=>1, :b=>3, :_features=>[\"A\", \"B\", \"C\"]}"
68+
assert_equal CU.inspect(defaults.(nil, {})), "{:a=>1, :b=>3, :_features=>[\"A\", \"B\", \"C\"]}"
6969
end
7070

7171
it "what" do
7272
defaults.merge!( _features: Declarative::Variables::Append(["A"]) ) do |name, options|
7373
{ _features: Declarative::Variables::Append( ["B", "D"] ) }
7474
end
7575

76-
_(defaults.(nil, {}).inspect).must_equal "{:_features=>[\"A\", \"B\", \"D\"]}"
76+
assert_equal CU.inspect(defaults.(nil, {})), "{:_features=>[\"A\", \"B\", \"D\"]}"
7777
end
7878
end
7979

@@ -91,7 +91,7 @@ class DefaultsOptionsTest < Minitest::Spec
9191
{ _features: ["B", "D"] }
9292
end
9393

94-
assert_equal "{:_features=>[\"A\", \"B\", \"D\"]}", defaults.(nil, {}).inspect
94+
assert_equal CU.inspect(defaults.(nil, {})), "{:_features=>[\"A\", \"B\", \"D\"]}"
9595

9696
assert_equal %{[Declarative] Defaults#merge! and #call still accept arrays and automatically prepend those. This is now deprecated, you should replace `ary` with `Declarative::Variables::Append(ary)`.\n}*2, $stderr.string
9797
end

test/definitions_test.rb

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,19 +13,19 @@ class DefinitionsTest < Minitest::Spec
1313
# #add works with name
1414
schema.add :id
1515
# get works with symbol
16-
_(schema.get(:id).inspect).must_equal '#<Declarative::Definitions::Definition: @options={:name=>"id"}>'
16+
assert_equal CU.inspect(schema.get(:id).inspect), '#<Declarative::Definitions::Definition: @options={:name=>"id"}>'
1717
# get works with string
18-
_(schema.get("id").inspect).must_equal '#<Declarative::Definitions::Definition: @options={:name=>"id"}>'
18+
assert_equal CU.inspect(schema.get("id").inspect), '#<Declarative::Definitions::Definition: @options={:name=>"id"}>'
1919

2020
# #add with name and options
2121
schema.add(:id, unique: true)
22-
_(schema.get(:id).inspect).must_equal '#<Declarative::Definitions::Definition: @options={:unique=>true, :name=>"id"}>'
22+
assert_equal CU.inspect(schema.get(:id).inspect), '#<Declarative::Definitions::Definition: @options={:unique=>true, :name=>"id"}>'
2323
end
2424

2525
it "overwrites old when called twice" do
2626
schema.add :id
2727
schema.add :id, cool: true
28-
_(schema.inspect).must_equal '{"id"=>#<Declarative::Definitions::Definition: @options={:cool=>true, :name=>"id"}>}'
28+
assert_equal CU.inspect(schema.inspect), '{"id"=>#<Declarative::Definitions::Definition: @options={:cool=>true, :name=>"id"}>}'
2929
end
3030

3131
it "#add with block" do
@@ -36,7 +36,7 @@ class DefinitionsTest < Minitest::Spec
3636
end
3737
end
3838

39-
_(schema.inspect).must_equal '{"artist"=>#<Declarative::Definitions::Definition: @options={:nested=>{"name"=>#<Declarative::Definitions::Definition: @options={:name=>"name"}>, "band"=>#<Declarative::Definitions::Definition: @options={:nested=>{"location"=>#<Declarative::Definitions::Definition: @options={:name=>"location"}>}, :name=>"band"}>}, :name=>"artist"}>}'
39+
assert_equal CU.inspect(schema.inspect), '{"artist"=>#<Declarative::Definitions::Definition: @options={:nested=>{"name"=>#<Declarative::Definitions::Definition: @options={:name=>"name"}>, "band"=>#<Declarative::Definitions::Definition: @options={:nested=>{"location"=>#<Declarative::Definitions::Definition: @options={:name=>"location"}>}, :name=>"band"}>}, :name=>"artist"}>}'
4040
end
4141

4242
it "#add with :nested instead of block" do
@@ -47,7 +47,7 @@ class DefinitionsTest < Minitest::Spec
4747

4848
schema.add :artist, nested: nested_schema
4949

50-
_(schema.inspect).must_equal '{"artist"=>#<Declarative::Definitions::Definition: @options={:nested=>{"name"=>#<Declarative::Definitions::Definition: @options={:name=>"name"}>}, :name=>"artist"}>}'
50+
assert_equal CU.inspect(schema.inspect), '{"artist"=>#<Declarative::Definitions::Definition: @options={:nested=>{"name"=>#<Declarative::Definitions::Definition: @options={:name=>"name"}>}, :name=>"artist"}>}'
5151
end
5252

5353

@@ -69,7 +69,7 @@ class DefinitionsTest < Minitest::Spec
6969

7070
schema.add :id, unique: false, inherit: true
7171

72-
_(schema.inspect).must_equal '{"artist"=>#<Declarative::Definitions::Definition: @options={:cool=>true, :nested=>{"name"=>#<Declarative::Definitions::Definition: @options={:name=>"name"}>, "band"=>#<Declarative::Definitions::Definition: @options={:crazy=>nil, :nested=>{"location"=>#<Declarative::Definitions::Definition: @options={:name=>"location"}>, "genre"=>#<Declarative::Definitions::Definition: @options={:name=>"genre"}>}, :name=>"band", :normal=>false}>}, :name=>"artist", :uncool=>false}>, "id"=>#<Declarative::Definitions::Definition: @options={:unique=>false, :value=>1, :name=>"id"}>}'
72+
assert_equal CU.inspect(schema.inspect), '{"artist"=>#<Declarative::Definitions::Definition: @options={:cool=>true, :nested=>{"name"=>#<Declarative::Definitions::Definition: @options={:name=>"name"}>, "band"=>#<Declarative::Definitions::Definition: @options={:crazy=>nil, :nested=>{"location"=>#<Declarative::Definitions::Definition: @options={:name=>"location"}>, "genre"=>#<Declarative::Definitions::Definition: @options={:name=>"genre"}>}, :name=>"band", :normal=>false}>}, :name=>"artist", :uncool=>false}>, "id"=>#<Declarative::Definitions::Definition: @options={:unique=>false, :value=>1, :name=>"id"}>}'
7373
end
7474

7575
it "#add with nested options followed by inherit: true" do
@@ -92,4 +92,4 @@ class DefinitionTest < Minitest::Spec
9292
definition.merge!(render: true)
9393
_(merged).must_equal(:name=>"name", render: false)
9494
end
95-
end
95+
end

test/heritage_test.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ module RepresenterA
2020
else
2121
exp = "[{:method=>:representation_wrap=, :args=>[true], :block=>nil}, {:method=>:property, :args=>[:name, {:enable=>true}], :block=>nil}, {:method=>:property, :args=>[:id, {}], :block=>#<Proc:@heritage_test.rb:4>}]"
2222
end
23-
assert_equal exp, RepresenterA.heritage.inspect
23+
assert_equal exp, CU.inspect(RepresenterA.heritage.inspect)
2424
end
2525

2626

@@ -42,7 +42,7 @@ module B
4242
else
4343
exp = "[{:method=>:property, :args=>[:name, {:render=>true, :nested=>{:render=>false}}], :block=>#<Proc:@heritage_test.rb:4>}]"
4444
end
45-
assert_equal exp, B.heritage.inspect
45+
assert_equal exp, CU.inspect(B.heritage.inspect)
4646
}
4747
end
4848

test/schema_test.rb

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,8 @@ class Concrete < Decorator
3636
it do
3737
Concrete.extend(Declarative::Inspect::Schema)
3838
Concrete.inspect
39-
_(Concrete.inspect.gsub(/\s/, "")).must_equal 'Schema:{
39+
40+
assert_equal CU.inspect(Concrete.inspect).gsub(/\s/, ""), 'Schema:{
4041
"links"=>#<Declarative::Definitions::Definition:@options={:render_nil=>true,:as=>"LINKS",:name=>"links"}>,
4142
"artist"=>#<Declarative::Definitions::Definition:@options={:render_nil=>true,:as=>"ARTIST",:cool=>true,:nested=>Schema:{
4243
"links"=>#<Declarative::Definitions::Definition:@options={:name=>"links"}>,
@@ -56,7 +57,7 @@ class InheritingConcrete < Concrete
5657
it do
5758
InheritingConcrete.extend(Declarative::Inspect::Schema)
5859
InheritingConcrete.inspect
59-
_(InheritingConcrete.inspect.gsub(/\s/, "")).must_equal 'Schema:{
60+
assert_equal CU.inspect(InheritingConcrete.inspect).gsub(/\s/, ""), 'Schema:{
6061
"links"=>#<Declarative::Definitions::Definition:@options={:render_nil=>true,:as=>"LINKS",:name=>"links"}>,
6162
"artist"=>#<Declarative::Definitions::Definition:@options={:render_nil=>true,:as=>"ARTIST",:cool=>true,:nested=>Schema:{
6263
"links"=>#<Declarative::Definitions::Definition:@options={:name=>"links"}>,
@@ -81,7 +82,7 @@ class ConcreteWithOptions < Decorator
8182
end
8283

8384
it do
84-
_(ConcreteWithOptions.extend(Declarative::Inspect::Schema).inspect).must_equal 'Schema: {"artist"=>#<Declarative::Definitions::Definition: @options={:cool=>true, :nested=>#<OpenStruct cool=true>, :name=>"artist"}>}'
85+
assert_equal CU.inspect(ConcreteWithOptions.extend(Declarative::Inspect::Schema).inspect), 'Schema: {"artist"=>#<Declarative::Definitions::Definition: @options={:cool=>true, :nested=>#<OpenStruct cool=true>, :name=>"artist"}>}'
8586
end
8687
end
8788

@@ -105,7 +106,7 @@ module D; end
105106
end
106107

107108
it do
108-
_(Twin.extend(Declarative::Inspect::Schema).inspect).must_equal 'Schema: {"id"=>#<Declarative::Definitions::Definition: @options={:a=>"a", :b=>"b", :first=>1, :nested=>Schema: {}, :name=>"id"}>}'
109+
assert_equal CU.inspect(Twin.extend(Declarative::Inspect::Schema).inspect), 'Schema: {"id"=>#<Declarative::Definitions::Definition: @options={:a=>"a", :b=>"b", :first=>1, :nested=>Schema: {}, :name=>"id"}>}'
109110
# :_features get merged.
110111
Twin.definitions.get(:id)[:nested].is_a? Twin::A
111112
Twin.definitions.get(:id)[:nested].is_a? Twin::B

test/test_helper.rb

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,13 @@
11
require "minitest/autorun"
22
require "declarative"
33
require "declarative/testing"
4-
require "ostruct"
4+
require "ostruct"
5+
require "trailblazer/core"
6+
7+
CU = Trailblazer::Core::Utils
8+
9+
Minitest::Spec.class_eval do
10+
def assert_equal(asserted, expected)
11+
super(expected, asserted)
12+
end
13+
end

test/variables_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ class DSLOptionsTest < Minitest::Spec
66
Variables = Declarative::Variables
77

88
after do
9-
_(Declarative::Inspect(defaults)).must_equal %{{:id=>1, :connections=>{:first=>1, :second=>2}, :list=>[3]}}
9+
assert_equal CU.inspect(Declarative::Inspect(defaults)), %{{:id=>1, :connections=>{:first=>1, :second=>2}, :list=>[3]}}
1010
end
1111

1212
#- Merge

0 commit comments

Comments
 (0)