Use robot short name to get robot account details

Author: esron

reconcile/test/utils/test_quay_api.py

@@ -281,7 +281,7 @@ def test_delete_repo_robot_permissions_raises_other_status_codes(
 
 @responses.activate
 def test_get_robot_account_details_success(quay_api: QuayApi) -> None:
-    robot_data = {"name": "test-robot", "description": "Test robot account"}
+    robot_data = {"name": f"{ORG}+test-robot", "description": "Test robot account"}
     permissions_data = {
         "permissions": [
             {"role": "team", "team": {"name": "test-team"}},
@@ -308,10 +308,10 @@ def test_get_robot_account_details_success(quay_api: QuayApi) -> None:
         status=200,
     )
 
-    result = quay_api.get_robot_account_details("test-robot")
+    result = quay_api.get_robot_account_details(f"{ORG}+test-robot")
 
     assert result is not None
-    assert result["name"] == "test-robot"
+    assert result["name"] == f"{ORG}+test-robot"
     assert result["description"] == "Test robot account"
     assert len(result["teams"]) == 1
     assert result["teams"][0]["name"] == "test-team"
@@ -328,15 +328,15 @@ def test_get_robot_account_details_not_found(quay_api: QuayApi) -> None:
         status=404,
     )
 
-    result = quay_api.get_robot_account_details("test-robot")
+    result = quay_api.get_robot_account_details(f"{ORG}+test-robot")
     assert result is None
 
 
 @responses.activate
 def test_list_robot_accounts_detailed(quay_api: QuayApi) -> None:
-    robots_data = {"robots": [{"name": "robot1"}, {"name": "robot2"}]}
-    robot1_details = {"name": "robot1", "description": "Robot 1"}
-    robot2_details = {"name": "robot2", "description": "Robot 2"}
+    robots_data = {"robots": [{"name": f"{ORG}+robot1"}, {"name": f"{ORG}+robot2"}]}
+    robot1_details = {"name": f"{ORG}+robot1", "description": "Robot 1"}
+    robot2_details = {"name": f"{ORG}+robot2", "description": "Robot 2"}
     permissions_data: dict[str, list[dict[str, str]]] = {"permissions": []}
 
     responses.add(
@@ -385,5 +385,5 @@ def test_list_robot_accounts_detailed(quay_api: QuayApi) -> None:
     result = quay_api.list_robot_accounts_detailed()
 
     assert len(result) == 2
-    assert result[0]["name"] == "robot1"
-    assert result[1]["name"] == "robot2"
+    assert result[0]["name"] == f"{ORG}+robot1"
+    assert result[1]["name"] == f"{ORG}+robot2"

reconcile/utils/quay_api.py

@@ -310,7 +310,10 @@ def delete_robot_account(self, robot_name: str) -> None:
 
     def get_robot_account_details(self, robot_name: str) -> dict[str, Any] | None:
         """Get detailed information about a robot account including teams and repositories"""
-        url = f"{self.api_url}/organization/{self.organization}/robots/{robot_name}"
+        robot_short_name = robot_name.split("+")[1]
+        url = (
+            f"{self.api_url}/organization/{self.organization}/robots/{robot_short_name}"
+        )
         r = requests.get(url, headers=self.auth_header, timeout=self._timeout)
         if r.status_code == 404:
             return None
@@ -321,7 +324,7 @@ def get_robot_account_details(self, robot_name: str) -> dict[str, Any] | None:
         # Get team memberships for this robot
         teams: list[dict[str, str]] = []
         try:
-            teams_url = f"{self.api_url}/organization/{self.organization}/robots/{robot_name}/permissions"
+            teams_url = f"{self.api_url}/organization/{self.organization}/robots/{robot_short_name}/permissions"
             teams_r = requests.get(
                 teams_url, headers=self.auth_header, timeout=self._timeout
             )
@@ -338,7 +341,7 @@ def get_robot_account_details(self, robot_name: str) -> dict[str, Any] | None:
         # Get repository permissions for this robot
         repositories: list[dict[str, str]] = []
         try:
-            repos_url = f"{self.api_url}/organization/{self.organization}/robots/{robot_name}/permissions"
+            repos_url = f"{self.api_url}/organization/{self.organization}/robots/{robot_short_name}/permissions"
             repos_r = requests.get(
                 repos_url, headers=self.auth_header, timeout=self._timeout
             )