Remove support for legacy GCM API

Author: alex-friedl

.github/copilot-instructions.md

@@ -2,7 +2,9 @@
 
 ## Project Overview
 
-This repository implements a Node.js module for sending push notifications across multiple platforms: Apple (APN), Google (GCM/FCM), Windows (WNS), Amazon (ADM), and Web-Push. The core logic is in `lib/` and `src/`, with each platform handled by a dedicated file (e.g., `sendAPN.js`, `sendFCM.js`).
+This repository implements a Node.js module for sending push notifications across multiple platforms: Apple (APN), Google (FCM), Windows (WNS), Amazon (ADM), and Web-Push. The core logic is in `lib/` and `src/`, with each platform handled by a dedicated file (e.g., `sendAPN.js`, `sendFCM.js`).
+
+**Note:** Legacy GCM (Google Cloud Messaging) support has been removed. All Android push notifications now route exclusively through Firebase Cloud Messaging (FCM).
 
 ## Architecture & Data Flow
 
@@ -21,29 +23,31 @@ This repository implements a Node.js module for sending push notifications acros
 
 ## Conventions & Patterns
 
-- **Platform-specific files:** Each push service has its own file for isolation and clarity.
+- **Platform-specific files:** Each push service has its own file for isolation and clarity. Legacy GCM is no longer supported.
 - **Unified Data Model:** The `data` object for notifications is normalized across platforms. See `README.md` for all supported fields.
 - **Error Handling:** Errors are unified and returned in the result array from `push.send`.
 - **RegId Format:** Prefer object format for registration IDs (`{id, type}`), but string format is supported for legacy reasons.
-- **Chunking:** Android tokens are chunked in batches of 1,000 automatically.
-- **Constants:** Use constants from `constants.js` for platform types.
+- **Android Routing:** All Android push notifications (both long regIds and ADM/AMZN tokens without explicit type) route through FCM.
+- **Chunking:** Android tokens are chunked in batches of 1,000 automatically by FCM.
+- **Constants:** Use constants from `constants.js` for platform types. Available constants: `FCM_METHOD`, `APN_METHOD`, `WNS_METHOD`, `ADM_METHOD`, `WEB_METHOD`, `UNKNOWN_METHOD`.
 
 ## Integration Points
 
 - **External Libraries:**
-  - APN: `node-apn`
-  - FCM: `firebase-admin`
-  - GCM: `node-gcm`
+  - APN: `@parse/node-apn`
+  - FCM: `firebase-admin` (all Android push notifications)
   - ADM: `node-adm`
   - WNS: `wns`
   - Web-Push: `web-push`
+  - Note: Legacy `node-gcm` library has been removed
 - **Credentials:** Place service account keys and certificates in appropriate locations (see `README.md` for examples).
 
 ## Key Files & Directories
 
-- `lib/` and `src/`: Main implementation (mirrored structure)
-- `test/`: Test cases and sample credentials
+- `lib/` and `src/`: Main implementation (mirrored structure, both CommonJS)
+- `test/`: Test cases (78 tests, all passing) and sample credentials
 - `README.md`: Usage, configuration, and data model reference
+- `.github/copilot-instructions.md`: This file - AI agent guidance
 
 ## Example Usage
 

README.md

@@ -54,7 +54,6 @@
     "@parse/node-apn": "7.0.1",
     "firebase-admin": "12.1.1",
     "node-adm": "0.9.1",
-    "node-gcm": "1.1.4",
     "web-push": "3.6.7",
     "wns": "0.5.4"
   },

package-lock.json

@@ -2,7 +2,6 @@ module.exports = {
   DEFAULT_TTL: 28 * 86400,
   GCM_MAX_TTL: 2419200, // 4 weeks in seconds (https://firebase.google.com/docs/cloud-messaging/http-server-ref#downstream-http-messages-json)
   APN_METHOD: "apn",
-  GCM_METHOD: "gcm",
   FCM_METHOD: "fcm",
   ADM_METHOD: "adm",
   WNS_METHOD: "wns",
@@ -71,6 +70,5 @@ module.exports = {
       // contentEncoding: '< Encoding type, e.g.: aesgcm or aes128gcm >'
     },
     isAlwaysUseFCM: false,
-    isLegacyGCM: false,
   },
 };

package.json

@@ -1,4 +1,3 @@
-const sendGCM = require("./sendGCM");
 const sendFCM = require("./sendFCM");
 const APN = require("./sendAPN");
 const sendADM = require("./sendADM");
@@ -11,7 +10,6 @@ const {
   WEB_METHOD,
   WNS_METHOD,
   ADM_METHOD,
-  GCM_METHOD,
   FCM_METHOD,
   APN_METHOD,
 } = require("./constants");
@@ -27,7 +25,6 @@ class PN {
       this.apn.shutdown();
     }
     this.apn = new APN(this.settings.apn);
-    this.useFcmOrGcmMethod = this.settings.isLegacyGCM ? GCM_METHOD : FCM_METHOD;
   }
 
   sendWith(method, regIds, data, cb) {
@@ -50,14 +47,14 @@ class PN {
     if (typeof regId === "object" && regId.id && regId.type) {
       return {
         regId: regId.id,
-        pushMethod: this.settings.isAlwaysUseFCM ? this.useFcmOrGcmMethod : regId.type,
+        pushMethod: this.settings.isAlwaysUseFCM ? FCM_METHOD : regId.type,
       };
     }
 
     // TODO: deprecated, remove of all cases below in v3.0
     // and review test cases
     if (this.settings.isAlwaysUseFCM) {
-      return { regId, pushMethod: this.useFcmOrGcmMethod };
+      return { regId, pushMethod: FCM_METHOD };
     }
 
     if (regId.substring(0, 4) === "http") {
@@ -73,15 +70,14 @@ class PN {
     }
 
     if (regId.length > 64) {
-      return { regId, pushMethod: this.useFcmOrGcmMethod };
+      return { regId, pushMethod: FCM_METHOD };
     }
 
     return { regId, pushMethod: UNKNOWN_METHOD };
   }
 
   send(_regIds, data, callback) {
     const promises = [];
-    const regIdsGCM = [];
     const regIdsFCM = [];
     const regIdsAPN = [];
     const regIdsWNS = [];
@@ -96,8 +92,6 @@ class PN {
 
       if (pushMethod === WEB_METHOD) {
         regIdsWebPush.push(regId);
-      } else if (pushMethod === GCM_METHOD) {
-        regIdsGCM.push(regId);
       } else if (pushMethod === FCM_METHOD) {
         regIdsFCM.push(regId);
       } else if (pushMethod === WNS_METHOD) {
@@ -112,11 +106,6 @@ class PN {
     });
 
     try {
-      // Android GCM / FCM (Android/iOS) Legacy
-      if (regIdsGCM.length > 0) {
-        promises.push(this.sendWith(sendGCM, regIdsGCM, data));
-      }
-
       // FCM (Android/iOS)
       if (regIdsFCM.length > 0) {
         promises.push(this.sendWith(sendFCM, regIdsFCM, data));
@@ -192,5 +181,4 @@ module.exports = PN;
 module.exports.WEB = WEB_METHOD;
 module.exports.WNS = WNS_METHOD;
 module.exports.ADM = ADM_METHOD;
-module.exports.GCM = GCM_METHOD;
 module.exports.APN = APN_METHOD;