Move setting of useFcmOrGcmMethod to setOptions

alex-friedl · alex-friedl · commit cf8741205856 · 2024-06-19T22:34:01.000+02:00
diff --git a/src/push-notifications.js b/src/push-notifications.js
@@ -21,9 +21,6 @@ import {
 class PN {
   constructor(options) {
     this.setOptions(options);
-    this.useFcmOrGcmMethod = this.settings.isLegacyGCM
-      ? GCM_METHOD
-      : FCM_METHOD;
   }
 
   setOptions(opts) {
@@ -32,6 +29,9 @@ class PN {
       this.apn.shutdown();
     }
     this.apn = new APN(this.settings.apn);
+    this.useFcmOrGcmMethod = this.settings.isLegacyGCM
+      ? GCM_METHOD
+      : FCM_METHOD;
   }
 
   sendWith(method, regIds, data, cb) {

Original file line number	Diff line number	Diff line change
`@@ -21,9 +21,6 @@ import {`
`21`	`21`	`class PN {`
`22`	`22`	`constructor(options) {`
`23`	`23`	`this.setOptions(options);`
`24`		`- this.useFcmOrGcmMethod = this.settings.isLegacyGCM`
`25`		`- ? GCM_METHOD`
`26`		`- : FCM_METHOD;`
`27`	`24`	`}`
`28`	`25`
`29`	`26`	`setOptions(opts) {`
`@@ -32,6 +29,9 @@ class PN {`
`32`	`29`	`this.apn.shutdown();`
`33`	`30`	`}`
`34`	`31`	`this.apn = new APN(this.settings.apn);`
	`32`	`+ this.useFcmOrGcmMethod = this.settings.isLegacyGCM`
	`33`	`+ ? GCM_METHOD`
	`34`	`+ : FCM_METHOD;`
`35`	`35`	`}`
`36`	`36`
`37`	`37`	`sendWith(method, regIds, data, cb) {`