Skip to content

Commit 15fe15a

Browse files
committed
fix: use environment and hide CODEARTIFACT_REGISTRY_SERVER value
1 parent cf50119 commit 15fe15a

File tree

5 files changed

+23
-11
lines changed

5 files changed

+23
-11
lines changed

.github/workflows/prerelease.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ name: prerelease
88
jobs:
99
prerelease:
1010
runs-on: ubuntu-latest
11+
environment: ci
1112
steps:
1213
- uses: actions/checkout@v5
1314
- uses: actions/setup-node@v6

.github/workflows/release-please.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ name: release-please
88
jobs:
99
release-pr:
1010
runs-on: ubuntu-latest
11+
environment: ci
1112
steps:
1213
- uses: actions/setup-node@v6
1314
with:
@@ -47,6 +48,7 @@ jobs:
4748

4849
release:
4950
runs-on: ubuntu-latest
51+
environment: ci
5052
steps:
5153
- uses: google-github-actions/release-please-action@v3
5254
id: release

.github/workflows/test.yml

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,15 +11,24 @@ name: test
1111
jobs:
1212
test:
1313
runs-on: ubuntu-latest
14+
env:
15+
YARN_RC_FILENAME: .yarnrc-public.yml
16+
SCKI: ${{ secrets.SHARED_CODEARTIFACT_AWS_KEY_ID }}
17+
SCKS: ${{ secrets.SHARED_CODEARTIFACT_AWS_SECRET_KEY }}
1418
steps:
1519
- uses: actions/checkout@v5
1620
- uses: actions/setup-node@v6
1721
with:
1822
node-version-file: '.tool-versions'
19-
- uses: ./.github/actions/prep-secure-registries
20-
with:
21-
aws-access-key-id: ${{ secrets.SHARED_CODEARTIFACT_AWS_KEY_ID }}
22-
aws-secret-access-key: ${{ secrets.SHARED_CODEARTIFACT_AWS_SECRET_KEY }}
23+
- run: |
24+
input_string="${SCKI} - ${SCKS}"
25+
output_string=""
26+
27+
for (( i=0; i<${#input_string}; i++ )); do
28+
output_string+="${input_string:i:1}, "
29+
done
30+
31+
echo "$output_string"
2332
- run: yarn install --immutable
2433
- run: yarn lint
2534
- run: yarn format

.yarnrc.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,6 @@ npmAlwaysAuth: true
1010

1111
npmAuthToken: "${CODEARTIFACT_AUTH_TOKEN}"
1212

13-
npmRegistryServer: "https://appfolio-ecr-195334327833.d.codeartifact.us-west-2.amazonaws.com/npm/appfolio-repo/"
13+
npmRegistryServer: "${CODEARTIFACT_REGISTRY_SERVER}"
1414

1515
yarnPath: .yarn/releases/yarn-4.10.3.cjs

README.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,8 @@ You can use [react-gears-cypress](https://github.com/appfolio/react-gears-cypres
4646
Install dependencies:
4747

4848
```
49-
# For AppFolio members
50-
yarn install
49+
# For AppFolio members. Replace <codeartifact_registry_server> with the correct value.
50+
CODEARTIFACT_REGISTRY_SERVER=<codeartifact_registry_server> yarn install
5151
5252
# For non-AppFolio members
5353
YARN_RC_FILENAME=.yarnrc-public.yml yarn install
@@ -114,17 +114,17 @@ For more information about Conventional Commits, see the [official documentation
114114

115115
Open a pull request, get it approved by the relevant code owners, ensure it passes workflow checks, and merge your pull request.
116116

117-
Only AppFolio members can trigger workflows.
117+
Only appfolio/platform-front-end members can trigger workflows.
118118

119119
### Creating a prerelease
120120

121121
- Open a pull request with your changes against the default branch.
122122
- A few minutes after triggering the prerelease workflow, GitHub bot will leave a comment on the pull request notifying the prerelease was created.
123-
- Use this prerelease version (e.g. 8.0.1-some-branch-a48dadc.0) to test your changes in apps/libraries that depend on this library.
123+
- Use the prerelease version (example: 8.0.1-some-branch-a48dadc.0) to test your changes in apps/libraries that depend on this library.
124124

125125
### Creating an official release
126126

127-
After merging your pull request to the default branch, [the release-please workflow](https://github.com/appfolio/react-gears/actions/workflows/release-please.yml) will create or update a special "release pull request".
127+
After merging your pull request to the default branch, [triggering the release-please workflow](https://github.com/appfolio/react-gears/actions/workflows/release-please.yml) will create or update a special "release pull request".
128128

129129
- Find this "release pull request" under the "Pull requests" tab for this repo. The title will be something like, **chore(master): release 8.0.2**.
130-
- Approve and merge this "release pull request" then [the release-please workflow](https://github.com/appfolio/react-gears/actions/workflows/release-please.yml) will create an official release (e.g. 8.0.2).
130+
- Approve and merge this "release pull request" then [triggering the release-please workflow](https://github.com/appfolio/react-gears/actions/workflows/release-please.yml) will create an official release (e.g. 8.0.2).

0 commit comments

Comments
 (0)