Skip to content

Commit 279d6ae

Browse files
fix(logs): remove warning logs for common/handled error events. (react-native-webview#2043)
* remove warning logs for common/handled error events. * re-add warn logs, but only if not handled Co-authored-by: Cristiano Coelho <[email protected]>
1 parent e33eea6 commit 279d6ae

File tree

3 files changed

+12
-3
lines changed

3 files changed

+12
-3
lines changed

src/WebView.android.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -211,13 +211,16 @@ class WebView extends React.Component<AndroidWebViewProps, State> {
211211
onLoadingError = (event: WebViewErrorEvent) => {
212212
event.persist(); // persist this event because we need to store it
213213
const { onError, onLoadEnd } = this.props;
214+
214215
if (onError) {
215216
onError(event);
217+
} else {
218+
console.warn('Encountered an error loading page', event.nativeEvent);
216219
}
220+
217221
if (onLoadEnd) {
218222
onLoadEnd(event);
219223
}
220-
console.warn('Encountered an error loading page', event.nativeEvent);
221224

222225
this.setState({
223226
lastErrorEvent: event.nativeEvent,

src/WebView.ios.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -195,13 +195,16 @@ class WebView extends React.Component<IOSWebViewProps, State> {
195195
onLoadingError = (event: WebViewErrorEvent) => {
196196
event.persist(); // persist this event because we need to store it
197197
const { onError, onLoadEnd } = this.props;
198+
198199
if (onLoadEnd) {
199200
onLoadEnd(event);
200201
}
202+
201203
if (onError) {
202204
onError(event);
205+
} else {
206+
console.warn('Encountered an error loading page', event.nativeEvent);
203207
}
204-
console.warn('Encountered an error loading page', event.nativeEvent);
205208

206209
this.setState({
207210
lastErrorEvent: event.nativeEvent,

src/WebView.macos.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -183,13 +183,16 @@ class WebView extends React.Component<MacOSWebViewProps, State> {
183183
onLoadingError = (event: WebViewErrorEvent) => {
184184
event.persist(); // persist this event because we need to store it
185185
const { onError, onLoadEnd } = this.props;
186+
186187
if (onLoadEnd) {
187188
onLoadEnd(event);
188189
}
190+
189191
if (onError) {
190192
onError(event);
193+
} else {
194+
console.warn('Encountered an error loading page', event.nativeEvent);
191195
}
192-
console.warn('Encountered an error loading page', event.nativeEvent);
193196

194197
this.setState({
195198
lastErrorEvent: event.nativeEvent,

0 commit comments

Comments
 (0)